Page MenuHomePhabricator

Add Ranker to translatewiki.net
Closed, ResolvedPublic4 Estimated Story Points

Description

Project information

Name: Ranker
Homepage: https://www.wikidata.org/wiki/User:Lucas_Werkmeister/Ranker
Project link: https://ranker.toolforge.org/
Code repository: https://gitlab.wikimedia.org/toolforge-repos/ranker

  • Source branch: main
  • Target branch: i18n – the bot should open merge requests, which I’ll then merge and deploy, same as for Wikidata Image Positions (T363626)

OS License: AGPLv3
Issue Tracker: Tool-ranker
Project contact: User:Lucas Werkmeister (Wikimedia and translatewiki.net)

Logo: None

Project description:
Ranker is a tool to edit the rank of multiple Wikidata (or Structured Data on Commons) statements at once.

NOTE: Section below will be filled by twn staff

Project setup checklist

Project configuration (for translation admins)

Namespace: NS_WIKIMEDIA
Prefix: wikidata-ranker-
Validators:

  • MediaWikiParameter
  • MediaWikiPlural
  • BraceBalance

Insertables:

  • MediaWikiInsertablesSuggester

Support: Tool-ranker

Concerns

Event Timeline

Currently, the code to make the tool translatable, including all the messages, is in a merge request that I haven’t merged yet. I would merge and deploy that as soon as you indicate that the project is acceptable for TWN, but let me know if you’d like it to be deployed earlier (then you can try out ?uselang=qqx live on the tool and see which messages are used).

Nikerabbit triaged this task as Medium priority.Jan 18 2025, 5:29 PM
Nikerabbit set the point value for this task to 2.
Wangombe changed the task status from Open to In Progress.Jan 20 2025, 9:29 PM
Wangombe claimed this task.

Mentioned in SAL (#wikimedia-cloud) [2025-01-21T10:13:37Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed c326b10184 (make tool translatable: T384061); also update pip and wheel

Currently, the code to make the tool translatable, including all the messages, is in a merge request that I haven’t merged yet. I would merge and deploy that as soon as you indicate that the project is acceptable for TWN, but let me know if you’d like it to be deployed earlier (then you can try out ?uselang=qqx live on the tool and see which messages are used).

I’ve merged and deployed the code now, so you should be able to import it from the main branch. You can see the messages in action e.g. here: https://ranker.toolforge.org/?uselang=qqx

@Wangombe Few notes:

  • Please take a look at some other Wikidata tools such as Wikidata Mismatch Finder, Wikidata Lexeme Forms to identify the file and namespace best suited to add this project to.
  • We could also add a BraceBalance validator.

@LucasWerkmeister - Can you please add https://gitlab.wikimedia.org/l10n-bot to the repository so that we can submit translations?

Wangombe removed the point value 2 for this task.

@LucasWerkmeister - Can you please add https://gitlab.wikimedia.org/l10n-bot to the repository so that we can submit translations?

Done.

Prefix: wikidata-ranker-

I’ve already included {{msg-wm|ranker-*}} templates in some of the message documentation strings, so I’d prefer to have just ranker- as the prefix. (Otherwise, I’ll have to update the docs.) The tool name is just Ranker, without “Wikidata” (unlike Wikidata Lexeme Forms and Wikidata Image Positions).

Change #1113134 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Add Ranker to translatewiki.net

https://gerrit.wikimedia.org/r/1113134

Change #1113134 merged by jenkins-bot:

[translatewiki@master] Add Ranker to translatewiki.net

https://gerrit.wikimedia.org/r/1113134

This project is now deployed on Translatewiki. Awiting exports before resolving this task.

I don’t see an export yet… it should’ve happened yesterday, right?

Also one comment from the Gerrit change is still open – the translations should probably be in the Wikimedia namespace, not in the MediaWiki namespace.

We've had trouble with exports and imports across translatewiki.net. I don't think the namespace issue mentioned in the Gerrit patch is a big issue as the messages can be moved to the NS_WIKIMEDIA namespace at a later point. We are looking into it, and will let you know ASAP.

Change #1115781 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update ssh gir url for Ranker

https://gerrit.wikimedia.org/r/1115781

Change #1115781 merged by jenkins-bot:

[translatewiki@master] Update ssh git url for Ranker

https://gerrit.wikimedia.org/r/1115781

Mentioned in SAL (#wikimedia-cloud) [2025-01-31T13:23:31Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed 19c821857d (l10n updates: fi, ko, lb, skr-arab, sr-ec; T384061)

Change #1115859 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

I also just realized I completely forgot to implement a language preference :D it should use the browser language if I’m not mistaken, but still, a preference would be nice to have.

Change #1118809 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Disable translations to Ranker temporarily

https://gerrit.wikimedia.org/r/1118809

Change #1118809 merged by jenkins-bot:

[translatewiki@master] Disable translations to Ranker temporarily

https://gerrit.wikimedia.org/r/1118809

Change #1118817 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Re-instate Ranker project

https://gerrit.wikimedia.org/r/1118817

Change #1118817 merged by jenkins-bot:

[translatewiki@master] Re-instate Ranker project

https://gerrit.wikimedia.org/r/1118817

abi_ moved this task from In Progress to Done on the LPL Essential (LPL Essential 2024 Nov-Jan) board.

I've moved the project to the proper namespace - Wikimedia.

Followed the following steps:

  1. Disabled translations to Ranker temporarily.
  2. Got the list of all translations: SELECT * FROM page WHERE page_namespace=8 AND page_title LIKE 'Ranker%';
  3. Created a text file that can be given as input to moveBatch.php script.
  4. Re-instanced translations to Ranker
  5. Ran createMessageIndex.php to populate the message index
  6. Tested some minor translations
  7. Exported the translations to check that exports still work.

I think things look OK, so I'm going to go ahead and mark this as done.

Change #1115859 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

No reaction to this, then?

Change #1115859 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

No reaction to this, then?

Apologies, I missed that. Let me review and deploy that tomorrow.

Change #1115859 merged by jenkins-bot:

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

Change #1115859 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

No reaction to this, then?

Apologies, I missed that. Let me review and deploy that tomorrow.

Deployed the change. Lets move this to Needs QA to ensure exports work as expected.

Mentioned in SAL (#wikimedia-cloud) [2025-02-12T18:57:54Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed 778c5bbd38 (add settings page for T384061)

Alright, thanks!

I also just realized I completely forgot to implement a language preference :D it should use the browser language if I’m not mistaken, but still, a preference would be nice to have.

Fixed ^^

abi_ moved this task from Need QA to Done on the LPL Essential (LPL Essential 2024 Nov-Jan) board.

Change #1115859 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[translatewiki@master] Update Ranker pull-branch

https://gerrit.wikimedia.org/r/1115859

No reaction to this, then?

Apologies, I missed that. Let me review and deploy that tomorrow.

Deployed the change. Lets move this to Needs QA to ensure exports work as expected.

PR: https://gitlab.wikimedia.org/toolforge-repos/ranker/-/merge_requests/6

I think we're good. Thanks for your patience @LucasWerkmeister