Page MenuHomePhabricator

Make growthexperiments_link_recommendations.gelr_data nullable in the per-wiki x1 databases
Closed, ResolvedPublic

Description

  1. ALTER TABLEs to run: ALTER TABLE /*_*/growthexperiments_link_recommendations CHANGE gelr_data gelr_data MEDIUMBLOB DEFAULT NULL; (commit)
  2. Where to run those changes: growthexperiments.dblist, per-wiki x1 databases
  3. When to run those changes: As soon as possible.
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Deployed to beta-wikis, no issues seen.
  6. If the data should be made available on the labs replicas and/or dumps: Not applicable.
  7. Is this schema change blocking a feature rollout?: Yes, blocks T382270: Store the fact that Add Link did not generate any recommendation for a page, don't try again

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
change_growthexperiments_link_recommendations_T384177: New schema changerepos/sre/schema-changes!31marosteguiT384177main
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Most of these tables are small enough that I think I can run this in the master with replication a a decent sleep, but I will send the gitlab merge request so it is tracked.

marostegui opened https://gitlab.wikimedia.org/repos/sre/schema-changes/-/merge_requests/31

change_growthexperiments_link_recommendations_T384177: New schema change

Marostegui triaged this task as Medium priority.Jan 20 2025, 4:22 PM
Marostegui moved this task from Triage to In progress on the DBA board.

This is now running in the master with some sleep in between wikis. It will take a few hours.

marostegui merged https://gitlab.wikimedia.org/repos/sre/schema-changes/-/merge_requests/31

change_growthexperiments_link_recommendations_T384177: New schema change