Lookup: support readonly state
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	CCiufo-WMF
	Jan 20 2025, 7:35 PM

Description

The Lookup component is missing a readonly state even though it uses a text input under the hood. The readonly state should not only match TextInput, ChipInput, etc but also prevent users from interacting with the menu or menu items.

Technical notes:

In T382340#10409415, @AnneT wrote:

Noting here that readonly styles and input behavior currently exist in Lookup because the readonly attribute gets passed to the internal TextInput. However, if there are menu items (such as the case of initial suggestions), the menu will open and be accessible even in the readonly state.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update Codex from v2.3.1 to v2.3.2	mediawiki/core	master	+242 -162
	Lookup: add readonly state and block menu interaction	design/codex	main	+18 -1

Customize query in gerrit

Related Objects

Mentioned In: T382340: Lookup, Select: support read-only state
Mentioned Here: T382340: Lookup, Select: support read-only state

Event Timeline

CCiufo-WMF created this task.Jan 20 2025, 7:35 PM

CCiufo-WMF triaged this task as Medium priority.

CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.

CCiufo-WMF set the point value for this task to 2.

CCiufo-WMF mentioned this in T382340: Lookup, Select: support read-only state.

CCiufo-WMF removed a parent task: T382340: Lookup, Select: support read-only state.

CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.Jan 30 2025, 6:25 PM

DTorsani-WMF added a project: good first task.May 3 2025, 6:14 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Salujapushpit claimed this task.Sep 3 2025, 6:04 PM

Salujapushpit subscribed.

Change #1184574 had a related patch set uploaded (by Pushpit; author: Pushpit):

[design/codex@main] [T384256] Lookup: add readonly state and block menu interaction

https://gerrit.wikimedia.org/r/1184574

gerritbot added a project: Patch-For-Review.Sep 3 2025, 7:04 PM

Salujapushpit added a project: RoadToWiki.Sep 3 2025, 7:06 PM

Change #1184574 had a related patch set uploaded (by Pushpit; author: Pushpit):

[design/codex@main] Lookup: add readonly state and block menu interaction

https://gerrit.wikimedia.org/r/1184574

Catrope moved this task from Backlog to In Progress on the Codex board.Sep 9 2025, 6:07 PM