Page MenuHomePhabricator

IP Reveal guidance: next/previous transition is left-to-right in right-to-left languages
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

Viewing the IP Reveal guidance dialog in an RTL language, pressing next the transition goes to the right and pressing previous it goes to the left.

I guess these should be the other way around for an RTL language, in the same direction the next and previous arrows appear.

Steps to reproduce problem
  1. On an environment with CheckUser and IP Info installed and $wgCheckUserEnableTempAccountsOnboardingDialog = true;
  2. Login as a user with the temporary-account-viewer group
  3. You might need to reset your preferences to see the dialog, you can do this with Special:ApiSandbox#action=options&format=json&optionname=checkuser-temporary-accounts-onboarding-dialog-seen&formatversion=2
  4. Go to Special:RecentChanges, Wishlist or page history
  5. A dialog should appear, click the next button

Expected behaviour: Page transition goes to the left.
Observed behaviour: Page transition goes to the right.

Environment

Wiki(s): local docker CheckUser 2.5 (b038249) 07:19, 16 January 2025.

Screenshots

Event Timeline

Tchanders subscribed.

I'm adding this to the sprint for consideration, but if it is too large, it can be moved out again.

Change #1146984 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CheckUser@master] onboarding: Don't flip directional transition styles

https://gerrit.wikimedia.org/r/1146984

Change #1146984 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] onboarding: Don't flip directional transition styles

https://gerrit.wikimedia.org/r/1146984

Djackson-ctr subscribed.

QA is completed, I have verified the new code changes have been implemented and is functioning as expected (IP Reveal Onboarding dialog: When user selects the Next arrow, it will move the Onboarding dialog page to the right for RTL languages... When user selects the Previous arrow, it will move the Onboarding dialog page to the left for RTL languages).