[Compose] Convert AboutActivity to use Compose
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	cooltey
	Jan 21 2025, 6:40 PM

Description

Convert the AboutActivty to Compose, with the converted Compose theme and styles.

Please note that the related LicenseActivity also needs to be converted.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T381826 [EPIC] Migrate XMLs to use Jetpack Compose
		Resolved		WRai-WMF	T384362 [Compose] Convert AboutActivity to use Compose

Event Timeline

cooltey created this task.Jan 21 2025, 6:40 PM

WRai-WMF claimed this task.Jan 21 2025, 6:44 PM

WRai-WMF moved this task from Epics in Progress to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.

WRai-WMF moved this task from Doing to Ready for future sprints on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Jan 23 2025, 6:35 PM

Please add screenshots for before vs after conversion.

Seddon moved this task from Ready for future sprints to Current Sprint on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Feb 11 2025, 5:29 PM

Seddon set the point value for this task to 3.

Seddon renamed this task from [M][Compose] Convert AboutActivity to use Compose to [Compose] Convert AboutActivity to use Compose.Feb 11 2025, 5:37 PM

Seddon added a project: Android Sprint 2025: Dagobah.Feb 11 2025, 5:40 PM

WRai-WMF added a comment.Feb 11 2025, 6:16 PM

This comment was removed by WRai-WMF.

WRai-WMF added a comment.Feb 11 2025, 6:18 PM

This comment was removed by WRai-WMF.

		{F58392725}
About Screen before		About Screen after


License screen before		License Screen after

Seddon moved this task from Current Sprint to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Feb 13 2025, 3:38 PM

Seddon moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Feb 19 2025, 3:34 PM

Seddon mentioned this in T386369: [Spike] [1 Days] Review implications and implementation of conversion of about screen to Jetpack Compose.Feb 25 2025, 5:31 PM

dbrant closed https://github.com/wikimedia/apps-android-wikipedia/pull/5246

Dbrant moved this task from Code Review to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Mar 12 2025, 9:27 PM

Notes for QA: no changes in behavior or appearance; just checking for breakages.

Testing on 2.7.50525-r-2025-03-17

Everything seems to be working. However, I see the below issue on one device: Pixel 6 Android 15

Tapping the "Retrofit" portion of the Retrofit (license) text/link is not working for me. It works fine on the OnePlus 8 on Android 13

I am not seeing this issue on my end.

Could you confirm whether only the 'Retrofit' link is not working or if other links are also failing to work on the device?
What does it do when you tap the "Retrofit" link on that device?

It's just this portion of the text (highlighted in the screenshot. Tapping 'retro' doesn't work, but '(license)' does

share_688228227419942508.png (2×1 px, 227 KB)

It's just a minor thing. It works fine on other devices.

Williamrai closed https://github.com/wikimedia/apps-android-wikipedia/pull/5417

Link working

Dbrant closed this task as Resolved.Apr 14 2025, 8:09 PM

	F58392790: license_after.png
	Feb 12 2025, 9:05 PM

	F58392786: licesnse_before.png
	Feb 12 2025, 9:05 PM

	Restricted File
	Feb 12 2025, 8:39 PM

	F58392720: new_about_after.png
	Feb 12 2025, 8:38 PM

[Compose] Convert AboutActivity to use ComposeClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

[Compose] Convert AboutActivity to use Compose
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...