rMW includes/parser/MagicWordFactory.php should sort both $mVariableIDs and $mDoubleUnderscoreIDs completely in alphabetical order.
After reading 'revisionuser' 'subpagename' 'talkspace' the impression might arrive that there is neither 'basepagename' nor 'rootpagename' defined.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MagicWordFactory.php: Polish code on $mVariableIDs and $mDoubleUnderscoreIDs | mediawiki/core | master | +69 -69 |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1268493 had a related patch set uploaded (by Elisapoly; author: Elisapoly):
[mediawiki/core@master] MagicWordFactory.php: Polish code on $mVariableIDs and $mDoubleUnderscoreIDs
Hello. I have polish the codes and make PR to the Gerrit: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1268493
Although, I don't understand the second sentence. Do I need to do something with the variables stated like 'basepagename' nor 'rootpagename'?
Change #1268493 merged by jenkins-bot:
[mediawiki/core@master] MagicWordFactory.php: Polish code on $mVariableIDs and $mDoubleUnderscoreIDs