Page MenuHomePhabricator
Create Task
Maniphest T384423

Migrate GrowthExperiments API tests to CommunityConfiguration 2.0
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In T369709: Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json, we switched (most) PHPUnit tests to use the CommunityConfiguration extension (rather than the legacy CC support). Within this tasks, we need to migrate all API tests in GrowthExperiments to also make use of Community Configuration 2.0. This is important to ensure our tests run with configuration reasonably similar to production, in case an issue is caused by the way how we integrate with the CommunityConfiguration extension or similar.

Credits to @Michael for thinking of this.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
testing(api): Do not set unnecessary user propertiesmediawiki/extensions/GrowthExperimentsmaster+0 -11
testing(api): Remove importDumpmediawiki/extensions/GrowthExperimentsmaster+0 -1 K
testing(api): Use CommunityConfiguration 2.0mediawiki/extensions/GrowthExperimentsmaster+0 -54
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Jan 22 2025, 9:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2025, 9:18 AM
Urbanecm_WMF moved this task from Backlog to Removing legacy Community Configuration on the Growth-Team (Maintenance) board.Jan 22 2025, 9:19 AM
Urbanecm_WMF triaged this task as Medium priority.Feb 17 2025, 3:55 PM
Urbanecm_WMF edited projects, added Growth-Team; removed Growth-Team (Maintenance).
Urbanecm_WMF moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.
Urbanecm_WMF added a comment.Feb 17 2025, 5:10 PM

Based on my investigation (https://wikimedia.slack.com/archives/GVD7X37RB/p1739810937225419), https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1120198), it seems that API tests don't actually need Community Configuration provisioned. This will likely involve removing the setting up infrastructure.

Urbanecm_WMF set the point value for this task to 1.Feb 17 2025, 5:13 PM
gerritbot added a comment.Feb 17 2025, 6:32 PM

Change #1120198 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Use CC2.0 in api-testing

https://gerrit.wikimedia.org/r/1120198

gerritbot added a project: Patch-For-Review.Feb 17 2025, 6:32 PM

Change #1120208 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] testing(api): Remove importDump

https://gerrit.wikimedia.org/r/1120208

gerritbot added a comment.Feb 17 2025, 6:32 PM

Change #1120209 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] testing(api): Do not set unnecessary user properties

https://gerrit.wikimedia.org/r/1120209

Urbanecm_WMF claimed this task.Feb 17 2025, 6:42 PM
Urbanecm_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Feb 17 2025, 8:43 PM

Change #1120198 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] testing(api): Use CommunityConfiguration 2.0

https://gerrit.wikimedia.org/r/1120198

gerritbot added a comment.Feb 17 2025, 8:44 PM

Change #1120208 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] testing(api): Remove importDump

https://gerrit.wikimedia.org/r/1120208

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18).Feb 17 2025, 9:00 PM
gerritbot added a comment.Feb 17 2025, 9:03 PM

Change #1120209 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] testing(api): Do not set unnecessary user properties

https://gerrit.wikimedia.org/r/1120209

Urbanecm_WMF closed this task as Resolved.Feb 18 2025, 9:25 AM
Urbanecm_WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits