Page MenuHomePhabricator
Create Task
Maniphest T384490

Include directives on a line with headings prevent the legacy parser from generating section edit links
Closed, ResolvedPublic
Actions

Description

Check this page. If you inspect the HTML, the <h1> tag has a mw:Transclusion typeof and is embedded in a section with data-mw-section-id set to -1.

Check the [[ [[ https://ar.wiktionary.org/w/index.php?title=%D9%85%D9%8E%D8%AB%D9%92%D9%88%D9%8E%D9%89&useparsoid=0 | legacy rendering of that same page ]] and there is no edit-section link.

Also seen on mgwiktionary pages. For example, legacy vs. Parsoid and look for "Fanononana" sections.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendorwmf/1.47.0-wmf.8+414 -121
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendormaster+414 -121
[parser] Return HeadingPFragments while preprocessingC. Scott Ananianmediawiki/corewmf/1.47.0-wmf.7+50 -7
[parser] Return HeadingPFragments while preprocessingC. Scott Ananianmediawiki/corewmf/1.47.0-wmf.8+50 -7
[parser] Return HeadingPFragments while preprocessingArlolramediawiki/coremaster+50 -7
Add a HeadingPFragment type to be returned by the preprocessorArlolramediawiki/services/parsoidmaster+64 -8
Bump wikimedia/parsoid to 0.21.0-a24C. Scott Ananianmediawiki/vendormaster+2 K -339
Match legacy section numbering with sol transparent on lineArlolramediawiki/services/parsoidmaster+188 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry created this task.Jan 22 2025, 3:52 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptJan 22 2025, 3:52 PM
Restricted Application added subscribers: hubaishan, Aklapper. · View Herald Transcript
ssastry mentioned this in T381658: Transcluded template-generated sections in parsoid read views are ignored by parser transformer leading to FOUC.Jan 22 2025, 3:54 PM
ssastry renamed this task from HandleParsoidSectionLinks: Edit Section links are generated for template-generated sections to HandleParsoidSectionLinks: Edit Section links are generated for some template-generated sections where legacy parser doesn't generate them.Jan 22 2025, 5:24 PM
ssastry updated the task description. (Show Details)
ABreault-WMF subscribed.Jan 22 2025, 6:08 PM

For the mgwiktionary one, the source of https://mg.wiktionary.org/w/index.php?title=Endrika:-fanononana-&action=edit shows

====...==== <noinclude>

which looks like what I pointed out at T368095#9912482

ABreault-WMF added a comment.Jan 22 2025, 6:10 PM

Similarly, https://ar.wiktionary.org/w/index.php?title=%D9%82%D8%A7%D9%84%D8%A8:%D8%B9%D8%B1%D8%A8%D9%8A%D8%A9&action=edit shows

<includeonly>=</includeonly>[[عَرَبِيَّة|فِي ٱللُّغَةِ ٱلْعَرَبِيَّةِ]]:<includeonly>=</includeonly>
[[تصنيف:عربية]]<noinclude>[[تصنيف:قوالب لغات]]</noinclude>
ABreault-WMF claimed this task.Jan 22 2025, 7:36 PM
ihurbain edited projects, added: Content-Transform-Team-WIP; removed: Content-Platform-Team.Jan 23 2025, 3:08 PM
ihurbain removed a project: Parsoid.Jan 23 2025, 3:20 PM
ABreault-WMF edited projects, added: Content-Platform-Team (Work In Progress); removed: Content-Transform-Team-WIP.Feb 20 2025, 10:08 PM
Restricted Application added a subscriber: alaa. · View Herald TranscriptFeb 20 2025, 10:08 PM
ABreault-WMF moved this task from Backlog to In Progress on the Content-Platform-Team (Work In Progress) board.Feb 20 2025, 10:08 PM
ABreault-WMF mentioned this in T387374: Compound templates prevent section edit links where legacy adds them.Feb 27 2025, 3:13 PM
MSantos moved this task from Uncategorized to Wiktionary on the Parsoid-Read-Views board.Mar 13 2025, 12:40 PM
MSantos edited projects, added: Parsoid-Read-Views (Wiktionary); removed: Parsoid-Read-Views.
gerritbot added a comment.Apr 1 2025, 2:43 AM

Change #1132793 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Match legacy section numbering

https://gerrit.wikimedia.org/r/1132793

gerritbot added a project: Patch-For-Review.Apr 1 2025, 2:43 AM
ABreault-WMF moved this task from In Progress to Code Review on the Content-Platform-Team (Work In Progress) board.Apr 1 2025, 7:35 PM
gerritbot added a comment.Apr 2 2025, 1:14 PM

Change #1132793 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Match legacy section numbering with sol transparent on line

https://gerrit.wikimedia.org/r/1132793

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 1:30 PM
ABreault-WMF moved this task from Code Review to To Deploy on the Content-Platform-Team (Work In Progress) board.Apr 2 2025, 3:30 PM
gerritbot added a comment.Apr 4 2025, 1:04 PM

Change #1134218 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

gerritbot added a project: Patch-For-Review.Apr 4 2025, 1:04 PM
gerritbot added a comment.Apr 4 2025, 1:26 PM

Change #1134218 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 1:30 PM
ABreault-WMF added a parent task: T391624: Parsoid section edit link issues.Apr 10 2025, 7:42 PM
ABreault-WMF added a comment.Apr 10 2025, 8:06 PM

Hmm, post-deploy and purge, there's still a diff,
https://ar.wiktionary.org/w/index.php?title=%D9%85%D9%8E%D8%AB%D9%92%D9%88%D9%8E%D9%89&useparsoid=0
https://ar.wiktionary.org/w/index.php?title=%D9%85%D9%8E%D8%AB%D9%92%D9%88%D9%8E%D9%89&useparsoid=1

The patch in T384490#10697038 only handles the top-level case. For templated sections, the include directives will have been processed so Parsoid won't know if they occurred on a line with the headings. Somewhat analogous to T387520. Maybe I should have gone the other direction and made the legacy parser not get tripped by these include directives on the line.

T214538 seems like another way forward.

ABreault-WMF renamed this task from HandleParsoidSectionLinks: Edit Section links are generated for some template-generated sections where legacy parser doesn't generate them to Include directives on a line with headings prevent the legacy parser from generating section edit links.Apr 10 2025, 8:08 PM
ABreault-WMF moved this task from To Deploy to In Progress on the Content-Platform-Team (Work In Progress) board.
ssastry moved this task from In Progress to Backlog on the Content-Platform-Team (Work In Progress) board.May 22 2025, 5:43 PM
ABreault-WMF triaged this task as Medium priority.Jun 3 2025, 6:57 PM
ABreault-WMF removed ABreault-WMF as the assignee of this task.Aug 7 2025, 2:30 PM
MSantos moved this task from Wiktionary to Small Size Wikipedias on the Parsoid-Read-Views board.Sep 25 2025, 2:35 PM
MSantos edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views (Wiktionary).
MSantos added a project: OKR-Work.Oct 20 2025, 2:11 PM
ABreault-WMF claimed this task.Jun 19 2026, 10:42 PM
ABreault-WMF moved this task from Backlog to In Progress on the Content-Platform-Team (Work In Progress) board.
gerritbot added a comment.Jun 20 2026, 1:47 AM

Change #1304193 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Return HeadingPFragments

https://gerrit.wikimedia.org/r/1304193

gerritbot added a project: Patch-For-Review.Jun 20 2026, 1:47 AM
gerritbot added a comment.Jun 22 2026, 6:56 PM

Change #1304192 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add a HeadingPFragment type to be returned by the preprocessor

https://gerrit.wikimedia.org/r/1304192

gerritbot added a comment.Jun 23 2026, 1:09 AM

Change #1304193 merged by jenkins-bot:

[mediawiki/core@master] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1304193

gerritbot added a comment.Jun 23 2026, 1:10 AM

Change #1304192 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add a HeadingPFragment type to be returned by the preprocessor

https://gerrit.wikimedia.org/r/1304192

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2026, 1:32 AM
gerritbot added a comment.Jun 23 2026, 5:26 AM

Change #1305015 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305015

gerritbot added a project: Patch-For-Review.Jun 23 2026, 5:26 AM
gerritbot added a comment.Jun 23 2026, 5:33 AM

Change #1305018 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305018

gerritbot added a comment.Jun 23 2026, 1:27 PM

Change #1305015 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305015

Stashbot mentioned this in T387520: Support section edit links to nested templates.Jun 23 2026, 1:29 PM
Stashbot mentioned this in T391624: Parsoid section edit link issues.
Stashbot mentioned this in T387521: Section titles failing to resolve redirected templates.
Stashbot mentioned this in T429624: Link to edit TemplateData is broken with Parsoid Read Views.

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:29:20Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Stashbot added a comment.Jun 23 2026, 1:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:31:31Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 23 2026, 1:42 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:41:53Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 12m 31s)

gerritbot added a comment.Jun 23 2026, 1:42 PM

Change #1305018 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305018

Stashbot added a comment.Jun 23 2026, 1:44 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:44:02Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Stashbot added a comment.Jun 23 2026, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:46:11Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be v

Stashbot added a comment.Jun 23 2026, 1:52 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:52:30Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 08m 29s)

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2026, 2:33 PM
gerritbot added a comment.Jun 25 2026, 2:50 PM

Change #1305690 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a project: Patch-For-Review.Jun 25 2026, 2:50 PM
gerritbot added a comment.Jun 25 2026, 3:44 PM

Change #1305690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a comment.Jun 25 2026, 4:22 PM

Change #1305719 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

gerritbot added a comment.Jun 25 2026, 4:35 PM

Change #1305719 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

Stashbot mentioned this in T429822: CTT tasks week of 2026-06-19.Jun 25 2026, 4:36 PM
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T353697: Parsoid/legacy parser {{Pre}} template rendering difference.
Stashbot mentioned this in T429688: mw-empty-elt wrapping does not take DOMFragments into account.
Stashbot mentioned this in T393295: Measurement plan + Analysis for the "Get Started" experiment (WE1.2.17, FY24/25).

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:36:37Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]]

Stashbot added a comment.Jun 25 2026, 4:38 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:38:41Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 25 2026, 4:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:46:32Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] (duration: 09m 54s)

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2026, 5:32 PM
ABreault-WMF mentioned this in T430367: Parsoid adds section edit links to post-expansion where the preprocessor omitted them.Jun 27 2026, 12:59 AM
ABreault-WMF closed this task as Resolved.Jun 27 2026, 1:05 AM

The rest of this is captured in T430367

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits