⚓ T384490 Include directives on a line with headings prevent the legacy parser from generating section edit links

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.21.0-a24	mediawiki/vendor	master	+2 K -339
	Match legacy section numbering with sol transparent on line	mediawiki/services/parsoid	master	+188 -23

		Status	Subtype	Assigned	Task
		Open		None	T391624 Parsoid section edit link issues
		Open		None	T384490 Include directives on a line with headings prevent the legacy parser from generating section edit links

ssastry created this task.Jan 22 2025, 3:52 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptJan 22 2025, 3:52 PM

Restricted Application added subscribers: hubaishan, Aklapper. · View Herald Transcript

ssastry mentioned this in T381658: Transcluded template-generated sections in parsoid read views are ignored by parser transformer leading to FOUC.Jan 22 2025, 3:54 PM

ssastry renamed this task from HandleParsoidSectionLinks: Edit Section links are generated for template-generated sections to HandleParsoidSectionLinks: Edit Section links are generated for some template-generated sections where legacy parser doesn't generate them.Jan 22 2025, 5:24 PM

ssastry updated the task description. (Show Details)

For the mgwiktionary one, the source of https://mg.wiktionary.org/w/index.php?title=Endrika:-fanononana-&action=edit shows

====...==== <noinclude>

which looks like what I pointed out at T368095#9912482

<includeonly>=</includeonly>[[عَرَبِيَّة|فِي ٱللُّغَةِ ٱلْعَرَبِيَّةِ]]:<includeonly>=</includeonly>
[[تصنيف:عربية]]<noinclude>[[تصنيف:قوالب لغات]]</noinclude>

ABreault-WMF claimed this task.Jan 22 2025, 7:36 PM

ihurbain edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Jan 23 2025, 3:08 PM

ihurbain removed a project: Parsoid.Jan 23 2025, 3:20 PM

ABreault-WMF edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team-WIP.Feb 20 2025, 10:08 PM

Restricted Application added a subscriber: alaa. · View Herald TranscriptFeb 20 2025, 10:08 PM

ABreault-WMF moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.Feb 20 2025, 10:08 PM

ABreault-WMF mentioned this in T387374: Compound templates prevent section edit links where legacy adds them.Feb 27 2025, 3:13 PM

MSantos moved this task from Uncategorized to Wiktionary on the Parsoid-Read-Views board.Mar 13 2025, 12:40 PM

MSantos edited projects, added Parsoid-Read-Views (Wiktionary); removed Parsoid-Read-Views.

Change #1132793 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Match legacy section numbering

https://gerrit.wikimedia.org/r/1132793

gerritbot added a project: Patch-For-Review.Apr 1 2025, 2:43 AM

ABreault-WMF moved this task from In Progress to Code Review on the Content-Transform-Team (Work In Progress) board.Apr 1 2025, 7:35 PM

Change #1132793 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Match legacy section numbering with sol transparent on line

https://gerrit.wikimedia.org/r/1132793

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 1:30 PM

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Apr 2 2025, 3:30 PM

Change #1134218 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

gerritbot added a project: Patch-For-Review.Apr 4 2025, 1:04 PM

Change #1134218 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 1:30 PM

ABreault-WMF added a parent task: T391624: Parsoid section edit link issues.Apr 10 2025, 7:42 PM

Hmm, post-deploy and purge, there's still a diff,
https://ar.wiktionary.org/w/index.php?title=%D9%85%D9%8E%D8%AB%D9%92%D9%88%D9%8E%D9%89&useparsoid=0
https://ar.wiktionary.org/w/index.php?title=%D9%85%D9%8E%D8%AB%D9%92%D9%88%D9%8E%D9%89&useparsoid=1

The patch in T384490#10697038 only handles the top-level case. For templated sections, the include directives will have been processed so Parsoid won't know if they occurred on a line with the headings. Somewhat analogous to T387520. Maybe I should have gone the other direction and made the legacy parser not get tripped by these include directives on the line.

T214538 seems like another way forward.

ABreault-WMF renamed this task from HandleParsoidSectionLinks: Edit Section links are generated for some template-generated sections where legacy parser doesn't generate them to Include directives on a line with headings prevent the legacy parser from generating section edit links.Apr 10 2025, 8:08 PM

ABreault-WMF moved this task from To Deploy to In Progress on the Content-Transform-Team (Work In Progress) board.

ssastry moved this task from In Progress to Backlog on the Content-Transform-Team (Work In Progress) board.May 22 2025, 5:43 PM

ABreault-WMF triaged this task as Medium priority.Jun 3 2025, 6:57 PM

ABreault-WMF removed ABreault-WMF as the assignee of this task.Aug 7 2025, 2:30 PM

MSantos moved this task from Wiktionary to Small Size Wikipedias on the Parsoid-Read-Views board.Sep 25 2025, 2:35 PM

MSantos edited projects, added Parsoid-Read-Views (Small Size Wikipedias); removed Parsoid-Read-Views (Wiktionary).

MSantos added a project: OKR-Work.Mon, Oct 20, 2:11 PM