Change #1113570 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@master] Hooks: Stop using deprecated DatabaseBlock call

https://gerrit.wikimedia.org/r/1113570

Change #1113570 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] Hooks: Stop using deprecated DatabaseBlock call

https://gerrit.wikimedia.org/r/1113570

Thanks, @Reedy, for the fix. Can we call this resolved for now?

To be honest, we should probably talk about disabling MediaWiki-extensions-StopForumSpam on Beta and Wikimedia production, as I think iPoid-Service is the more modern, generalizable solution for this sort of thing.

I was talking to @kostajh and it seems like StopForumSpam isn't superseded by IPoid because they aren't necessarily the same IPs (although someone would have to verify that), and IPoid isn't yet used for preventing actions although there is an epic for that: https://phabricator.wikimedia.org/T354599

So I think it's still a question if it makes sense to continue to maintain sfs. Ongoing ownership of it is another question and whether it sits well with the security team.

Some relevant tasks:
T332003: Evaluate StopForumSpam operations in es.wikiversity
T273220: Deploy StopForumSpam extension to production
T334859: Allow more granular restrictions in StopForumSpam
T335040: Run SFS after checking for on-wiki blocks (and other anti-abuse features too?)

To be clear - I was suggesting that the StopForumSpam data be integrated as a new data source for the iPoid service. ext:StopForumSpam also is not currently used to prevent actions in Wikimedia production, as it is not currently set to enforce mode on any Wikimedia project. With the newer and far more general iPoid service available, it would seemingly make sense to leverage that system as opposed to revisiting a crufty, mostly-unmaintained, ultra-specific MediaWiki extension, given the appalling amounts of Technical-Debt we continue to collect. I would note that the Security-Team currently has not prioritized any efforts around the continued deployment or maintenance of ext:StopForumSpam. It also appears that @kostajh was at least generally accepting of this approach as discussed in T273220#10163323.

revisiting a crufty, mostly-unmaintained, ultra-specific MediaWiki extension

T194746: Bundle StopForumSpam extension with the next MediaWiki release proposed to bundle it to MediaWiki. For what it's worth, StopForumSpam is a self-contained extension (not requiring installing any other services), so for 3rd party wikis it is better since we should not force them to have an IPoid installation, and our one may not be open to public due to Spur Term of Use.

In T384545#10571660, @Bugreporter wrote:

For what it's worth, StopForumSpam is a self-contained extension (not requiring installing any other services), so for 3rd party wikis it is better since we should not force them to have an IPoid installation, and our one may not be open to public due to Spur Term of Use.

Yes, sorry if I wasn't clear in my previous comment. I did not mean that we should archive, retire or otherwise "delete" ext:StopForumSpam. The current codebase should work fine on pretty much any installation of MediaWiki and is a simple, drop-in anti-spam solution that lots of MediaWiki operators should feel free to use. I specifically meant that it likely doesn't make sense to continue pursuing ext:StopForumSpam as a solution for Wikimedia Production, with the existence and deployment of the preferred iPoid-Service.