Page MenuHomePhabricator

Monthly convert template broken (monthly_convert.es_MX.html)
Closed, ResolvedPublic

Description

The recurring queue consumer failed today. After looking at the associated weblogs, I spotted the following:

2025-01-23 13:40:05,467 ERROR   civicrm.wmf.INFO: thank_you: Calling ThankYou::render  
2025-01-23 13:40:05,559 ERROR   civicrm.wmf.INFO: wmf_common: Aborting DB transaction.  
2025-01-23 13:40:05,579 ERROR   civicrm.wmf.ERROR: wmf_common: UNHANDLED ERROR. Halting dequeue loop. Exception: Message was not parsed due to invalid smarty syntax: Syntax error in template "eval:{crmScope extensionKey=""}{capture assig..."  on line 43 "<!-- TI_BEGIN["version":1,"sourceUrl":"","name":"monthly_convert.es_MX.html","revision":20210413,"currency":"{$currency}"]TI_END -->{/crmScope}" unclosed '{if}' tag

I looked over the smarty email templates in CiviCRM and found the unclosed {if} block:

Template: WMF Monthly convert - Spanish (Latin America)
Template code: (Line 31)

Esta donación te será debitada una vez por {if $frequency_unit && $frequency_unit==='month'}mes {elseif $frequency_unit && $frequency_unit==='year'}año {/if}hasta que nos solicites lo contrario{if $frequency_unit && $frequency_unit==='month'}. Cada enero, te enviaremos un resumen de tus contribuciones correspondientes al año anterior. Si por algún motivo deseas dejar de donar, sigue estas <a href="https://donate.wikimedia.org/wiki/Special:LandingCheck?landing_page=Cancel_or_change_recurring_giving&basic=true&language={$locale}">sencillas instrucciones de cancelación</a>.</p>

Issue: The second {if} block in the above snippet does not have a corresponding closing {\if} block

This one -->{if $frequency_unit && $frequency_unit==='month'}. Cada enero, te enviaremos un resumen de tus contribuciones correspondientes al año anterior. Si por algún motivo deseas dejar de donar, sigue estas

Event Timeline

Hello everyone, I forgot to put the {/if} closing statement at the end of the sentence, which means I forgot to preview the code before saving, my apologies. It should be fixed properly now. Best FYI @RLopez-WMF and @PanosTr

XenoRyet set Final Story Points to 2.