Page MenuHomePhabricator

Update skins to support different logos at different resolutions
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

To support T373208 some changes are needed in skin code to support display of different images at different screen resolutions

User story

As a reader visiting the mobile site, it should be clear from the footer that I am on a Wikimedia site powered by MediaWiki

Requirements

  • The icons in the footer are different depending on the screen resolution on both Vector 2022 and Minerva
  • When I resize the icons in the footer collapse into squares like so:

Screenshot 2025-01-23 at 7.45.50 AM.png (152×646 px, 51 KB)
=>
Screenshot 2025-01-23 at 7.45.38 AM.png (148×304 px, 20 KB)

  • The compact icon can be described in $wgFooterIcons

e.g.

$wgFooterIcons['poweredby']['mediawiki']['srcset'] = [
	"(max-width: 720px)" => "https://en.wikipedia.org/static/images/mobile/mediawiki.png",
];
$wgFooterIcons['copyright']['copyright']['srcset'] = [
	"(max-width: 720px)" => "https://en.wikipedia.org/static/images/mobile/wikimedia.png",
];

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1113827 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [POC]: Skins support responsive footer icons

https://gerrit.wikimedia.org/r/1113827

Jdlrobson-WMF set the point value for this task to 3.

Per team estimation (although might bump up to 5 pending further discussion)

If the picture element seems overkill we could also introduce support for the sizes attribute since the footer icons already support srcset. This would presumably be a simpler change (albeit with more caution).

Change #1113827 merged by jenkins-bot:

[mediawiki/core@master] Skin: Support responsive footer icons

https://gerrit.wikimedia.org/r/1113827

Vector-2022 in beta cluster:

grafik.png (704×467 px, 89 KB)

Once the patch properly rides the rain we can switch the wikimedia button too (I'd say change the link to https://wikimedia.org as well)

Change #1119579 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Footer: Wikimedia icon should collapse at lower resolutions

https://gerrit.wikimedia.org/r/1119579

Change #1119579 merged by jenkins-bot:

[operations/mediawiki-config@master] Footer: Wikimedia icon should collapse at lower resolutions

https://gerrit.wikimedia.org/r/1119579

Mentioned in SAL (#wikimedia-operations) [2025-02-19T21:28:07Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1119579|Footer: Wikimedia icon should collapse at lower resolutions (T384619)]], [[gerrit:1120609|Update Search AB test config, increase bucketing/sampling rates for eu/ca, deploy to testwiki (T386734)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-19T21:31:10Z] <cjming@deploy2002> jdlrobson, cjming, bwang: Backport for [[gerrit:1119579|Footer: Wikimedia icon should collapse at lower resolutions (T384619)]], [[gerrit:1120609|Update Search AB test config, increase bucketing/sampling rates for eu/ca, deploy to testwiki (T386734)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-19T21:39:55Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1119579|Footer: Wikimedia icon should collapse at lower resolutions (T384619)]], [[gerrit:1120609|Update Search AB test config, increase bucketing/sampling rates for eu/ca, deploy to testwiki (T386734)]] (duration: 11m 47s)

Change #1121098 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Take 2: Footer: Wikimedia icon should collapse at lower resolutions""

https://gerrit.wikimedia.org/r/1121098

Change #1121098 merged by jenkins-bot:

[operations/mediawiki-config@master] Take 2: Footer: Wikimedia icon should collapse at lower resolutions""

https://gerrit.wikimedia.org/r/1121098

Mentioned in SAL (#wikimedia-operations) [2025-02-20T13:25:12Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1121098|Take 2: Footer: Wikimedia icon should collapse at lower resolutions"" (T384619)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-20T13:28:11Z] <ladsgroup@deploy2002> ladsgroup, jdlrobson: Backport for [[gerrit:1121098|Take 2: Footer: Wikimedia icon should collapse at lower resolutions"" (T384619)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-20T13:37:07Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1121098|Take 2: Footer: Wikimedia icon should collapse at lower resolutions"" (T384619)]] (duration: 11m 54s)

Jdlrobson-WMF updated the task description. (Show Details)

Fix verified on https://en.wikipedia.org/wiki/Main_Page

Screenshot 2025-02-24 at 9.52.33 AM.png (936×494 px, 166 KB)

We can now go ahead and add the menu on Minerva ==> T373208