Page MenuHomePhabricator

Conduct pre-deployment QA of showing multiple Reference Checks in a given edit
Closed, ResolvedPublic

Description

In T379131, we will be running an A/B test to evaluate the impact of removing the upward boundary on how many Reference Checks people can see within a given edit.

Before beginning this A/B test, we want to verify the experience is behaving in the ways we expect it to. We're going to use this ticket or organize this QA effort.

Requirements

Requirements

On mobile and desktop...

  1. Visit https://test.wikipedia.org/wiki/Main_Page
  2. Add a minimum of ≥50 characters of text as new paragraphs in ≥2 places within an article
  3. Verify all facets of the Reference Check/Multi-Check experience works as expected. This includes, and is not limited to...
    • Declining to add a reference
    • Accepting to add a reference
    • Navigating between different Reference Check instances
  4. Document the issues that surface during "1-3" in the section below

Issues

Both on Desktop and Mobile:

  1. After step 2, if I discard an edit session and start a new edit session then add multiple new paragraphs, no reference checks are being activated for those, until full page reload.
  1. After step 2, when there are multiple new paragraphs, even though there are multiple checks only one check can be responded at a time. After each check has been responded, it opens up the save dialog even though there are more checks that needs to be dealt with (the one for second paragraph).

It's only after the save dialog is discarded, the check for the second paragraph shows up upon trying to save for the second time.

  1. After discarding the Save dialog, if I keep adding more paragraphs, no further reference checks get activated upon clicking on "Publish Changes".

On Mobile:

  1. If I go back to the edit mode from the pre-publish moment, I am not being able to abandon the edit session because the cross button the toolbar stays disabled.

Event Timeline

ppelberg updated the task description. (Show Details)

Change #1114792 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Enable VisualEditor's EditCheck multiple-check mode on testwiki

https://gerrit.wikimedia.org/r/1114792

Change #1114792 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable VisualEditor's EditCheck multiple-check mode on testwiki

https://gerrit.wikimedia.org/r/1114792

Change #1114804 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Move VE EditCheck testwiki enabling into the correct file

https://gerrit.wikimedia.org/r/1114804

Change #1114804 merged by jenkins-bot:

[operations/mediawiki-config@master] Move VE EditCheck testwiki enabling into the correct file

https://gerrit.wikimedia.org/r/1114804

Mentioned in SAL (#wikimedia-operations) [2025-01-28T22:30:19Z] <jhuneidi@deploy2002> Finished scap sync-world: Backport for [[gerrit:1114804|Move VE EditCheck testwiki enabling into the correct file (T384658)]], [[gerrit:1114425|Condense wikivoyage configuration options for Parsoid Read Views (T365367)]] (duration: 13m 48s)

  1. After step 2, if I discard an edit session and start a new edit session then add multiple new paragraphs, no reference checks are being activated for those, until full page reload.

I can't reproduce this one. Is there anything unstated that you're doing?

  1. After step 2, when there are multiple new paragraphs, even though there are multiple checks only one check can be responded at a time. After each check has been responded, it opens up the save dialog even though there are more checks that needs to be dealt with (the one for second paragraph).

Should have been fixed earlier this week by this patch. Testwiki is on the train, though, so it wouldn't be fixed there yet.

  1. After discarding the Save dialog, if I keep adding more paragraphs, no further reference checks get activated upon clicking on "Publish Changes".

I also couldn't reproduce this one, though it sounds suspiciously similar to the first one.

[mobile] 1. If I go back to the edit mode from the pre-publish moment, I am not being able to abandon the edit session because the cross button the toolbar stays disabled.

Technically this one is because the VE surface loses focus when that happens -- note that the other things in the toolbar are also disabled. Tapping into the surface should re-enable everything.

  1. After step 2, if I discard an edit session and start a new edit session then add multiple new paragraphs, no reference checks are being activated for those, until full page reload.

I can't reproduce this one. Is there anything unstated that you're doing?

Yes, sorry I missed mentioning that it happens after responding "No" to the Reference Check prompt and then discarding the edit session by switching to read mode.
Basically, it seems to me if the same number of paragraph gets added in the next session it seemed to be remembering the response for the next session and not activating reference check. If I responded "No" to two paragraphs in the previous session, in the next session it's activating the reference check when I add a third paragraph.

  1. After discarding the Save dialog, if I keep adding more paragraphs, no further reference checks get activated upon clicking on "Publish Changes".

I also couldn't reproduce this one, though it sounds suspiciously similar to the first one.

Yes, it might be the same issue since this one also happens after responding "No" to the reference check but staying in the same session not discarding edit, just discarding the Save dialog.

Okay, that turns out to be if you're adding a paragraph immediately after the preceding ones -- if you add one elsewhere in the document it should catch that. It's because the dismissal is tracked by fragments, which are growing to include the following content. I'll look into that.

Change #1117238 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheck: exclude insertions from dismissed fragments

https://gerrit.wikimedia.org/r/1117238

Change #1117238 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: exclude insertions from dismissed fragments

https://gerrit.wikimedia.org/r/1117238

Okay! I believe that everything but the "mobile back-button is disabled" issue should be fixed.

Ryasmeen edited projects, added Verified; removed Editing QA.

Okay! I believe that everything but the "mobile back-button is disabled" issue should be fixed.

Confirmed all the issues are now fixed.

ppelberg claimed this task.