ApiEchoMute.php on l
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ammarpad
	Jan 24 2025, 10:49 AM

Project Tags

Referenced Files

None

Subscribers

Description

Error

service.version: 1.44.0-wmf.13
trace.id: 6931213b-a5c2-479a-a8cc-12bd39a4aab9
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref() must be of the type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php(117)
#0	/srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php(58)	MediaWiki\Extension\Notifications\Api\ApiEchoMute->parsePref(null)
#1	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(1973)	MediaWiki\Extension\Notifications\Api\ApiEchoMute->execute()
#2	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(941)	MediaWiki\Api\ApiMain->executeAction()
#3	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(912)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#4	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#5	/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Api\ApiEntryPoint->execute()
#6	/srv/mediawiki/php-1.44.0-wmf.13/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#7	/srv/mediawiki/w/api.php(3)	require(string)
#8	{main}

Impact

Notes

Details

Request URL: https://ja.wikipedia.org/w/api.php

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Handle null option value in echomute api	Umherirrender	mediawiki/extensions/Echo	master	+1 -1
	Handle null option value in echomute api	Reedy	mediawiki/extensions/Echo	wmf/1.44.0-wmf.14	+1 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Umherirrender	T384694 TypeError: Argument 1 passed to MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref() must be of the type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php on l
			· · ·

Event Timeline

Ammarpad created this task.Jan 24 2025, 10:49 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 24 2025, 10:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Type declaration added in ace1750753516e97b3fc8bdb98f12c5d8c426c27

Change #1114039 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Handle null option value in echomarkread api

https://gerrit.wikimedia.org/r/1114039

gerritbot added a project: Patch-For-Review.Jan 24 2025, 7:36 PM

Without the type hint it would end calling preg_split with null, that seems to throws deprecation notice under php8.1, so this finding helps to make the code future proof.

Ammarpad merged a task: T385090: TypeError: MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref(): Argument #1 ($prefValue) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php on .Jan 29 2025, 6:59 PM

Ammarpad added a subscriber: Reedy.

Urbanecm_WMF triaged this task as Low priority.Jan 30 2025, 11:54 AM

Urbanecm_WMF edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.

Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.

Change #1114039 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Handle null option value in echomute api

https://gerrit.wikimedia.org/r/1114039

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 30 2025, 1:00 PM

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Jan 30 2025, 2:29 PM

Change #1115431 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/extensions/Echo@wmf/1.44.0-wmf.14] Handle null option value in echomute api

https://gerrit.wikimedia.org/r/1115431

Reedy closed this task as Resolved.Jan 30 2025, 3:29 PM

Reedy assigned this task to Umherirrender.

Change #1115431 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.44.0-wmf.14] Handle null option value in echomute api

https://gerrit.wikimedia.org/r/1115431

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.14; 2025-01-28); removed: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 30 2025, 4:00 PM

Krinkle moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:41 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 3:30 AM

TypeError: Argument 1 passed to MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref() must be of the type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php on lClosed, ResolvedPublicPRODUCTION ERRORActions