Page MenuHomePhabricator

Gerrit needs a very wide screen or has big horizontal scroll
Closed, DeclinedPublic

Description

Ugly scrollbars

I have 1440x900 resolution on my laptop. Yet the Gerrit interface doesn't fit in very well.

It is kind of problem with too long lines in commit messages, but on the other hand those are not strictly enforced, and gerrit should handle them better.

I either get ugly scrollbars or extra wide page. See the attached images.


Version: unspecified
Severity: minor

attachment Wide-gerrit-1.png ignored as obsolete

Details

Reference
bz36471

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:19 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz36471.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 10502
Extra wide page

attachment Wide-gerrit-2.png ignored as obsolete

That is why we want to use short commit messages.

Also, Roan was possibly adding some CSS to line-wrap long commit messages there.

I know it's not coming *soon*, but 2.4 improves the UI here a lot...just something to keep in mind.

(In reply to comment #3)

I know it's not coming *soon*, but 2.4 improves the UI here a lot...just
something to keep in mind.

Here's what the interface looks like in 2.4: http://gerrit-dev.wmflabs.org/r/#/c/9/1/.gitmodules

Actually this was in 2.3, not just 2.4. It's a bit too wide for my Android devices (phone & tablet), but it's certainly usable. On my laptop, I can take the resolution down as far as 800x600 and it's still a bit too wide--but again, perfectly usable.

I'm inclined to mark this WORKSFORME.

We're using Gerrit 2.4 and it doesn't look fixed to me. The computed width of my current dashboard table is 1163px, which is typical and kind of inconvenient when you have a screen width of 1050px. The V/R marks are almost never visible without horizontal scrolling. Removing the white-space:nowrap from the remaining table cells that have it improves the display enormously, see the screenshots which I will attach shortly.

Created attachment 11164
Tim's dashboard in 2.4

1163px wide dashboard in 2.4

Attached:

gerrit-dashboard-nowrap.png (1×1 px, 302 KB)

Created attachment 11165
Tim's dashboard without nowrap

Same dashboard view, hacked with Firebug to remove the white-space:nowrap rules.

Attached:

gerrit-dashboard-wrap.png (1×1 px, 319 KB)

Submitted a patch upstream to fix this.

https://gerrit-review.googlesource.com/#/c/38260/

Thanks Tim, I hadn't noticed this being too wide (initial focus of the bug was on commit messages).

Merged into upstream, with a second fix to my original commit. Doubt it'll make the 2.5 release, but it'll definitely make 2.6.

Created attachment 11768
Search bar way beyond the screen in 2.6

(In reply to comment #10)

Merged into upstream, with a second fix to my original commit. Doubt it'll
make
the 2.5 release, but it'll definitely make 2.6.

Actually it's way worse in 2.6. With 2.4, most of the search bar was within the screen.

Attached:

GerritWide.png (768×1 px, 104 KB)

Previous comments were asking for wide commit messages and wide change tables to be fixed--both if which have been.

The search bar wasn't brought up in previous comments at all (and I didn't do any work on it). I'm not opposed to improvements though :)

Created attachment 11775
Commit message going way beyond the screen

(In reply to comment #12)

Previous comments were asking for wide commit messages and wide change tables
to be fixed--both if which have been.

It's also commit messages for me.
I think you changed something with the logo? I see less white space next to it, good.

The search bar wasn't brought up in previous comments at all (and I didn't do
any work on it). I'm not opposed to improvements though :)

Would another bug be better, or – in general – how can one help?

Attached:

GerritWideCommit.png (768×1 px, 103 KB)

We still need to wrap commit messages properly. We have a table, use it.

Also, can I get a screenshot of the search bar problem and what exactly we should fix?

(In reply to comment #14)

Also, can I get a screenshot of the search bar problem and what exactly we
should fix?

Quoting myself from https://gerrit.wikimedia.org/r/#/c/58082/ : «I have a 1024x768px screen and with "My" tab selected I lack 250px of space to reach the end (arrow to open settings).»
That CSS change should help, I can add a screenshot... no I already did, attachment 11768 look top right.

(In reply to comment #14)

Also, can I get a screenshot of the search bar problem and what exactly we
should fix?

Up to and including patch set 3 of Iaedbea9b5f43ac this change doesn't actually work.

The problem (screenshot of current deployment, no changes):

Screenshot with Iaedbea9b5f43ac,ps3 applied:

What we need:

  • Hide logo and move everything else over (it has position absolute, hiding it doesn't collapse the layout).

Restoring the original bug summary, with addition of "horizontal scroll" specification: the new bug summary doesn't describe a problem but a specific goal regarding the problem.

  • Bug 69036 has been marked as a duplicate of this bug. ***
greg lowered the priority of this task from Medium to Low.Sep 10 2015, 11:05 PM

This is fixed in polygerrit and upstream are not doing any improvements to the gwt skin but welcome contributions from any volunteers that will improve it.

Polygerrit is mobile friendly, it resizes depending on screen size. It also resizes on desktop.

To test for your self please try

https://gerrit-new.wmflabs.org/?polygerrit=1

or

https://gerrit-review.googlesource.com/?polygerrit=1

Upstream are going with polygerrit. they are unlikely to allow any changes like this,

demon subscribed.

Yes. Upstream is redoing their UI which mostly solves this. I also think it's outside the scope of something we could accomplish in the wishlist survey.

Upstream are also doing this https://gerrit-review.googlesource.com/#/c/94671/ proposal for the ux. Which doesn't mention the long scroll bar's, but does mention the need to have a good ui.

I have filled this T158479 as we need to figure out a way to get polygerrit to work on our url.

The problem (screenshot of current deployment, no changes):

Screenshot with Iaedbea9b5f43ac,ps3 applied:

Both of these links give me:

CloudApp

Nothing lives here.

This isn't the page you were looking for. Sorry about that! Contact us support@getcloudapp.com if you think we can help. Or if you'd like us to share our GIF of the day with you. Or a poem.

I hope you've since learned to not trust such outside services for screenshots on tasks. :-)

I think we can close this as declined as polygerrit will be the new way to go ui wise once it is all ready.

Paladox lowered the priority of this task from Low to Lowest.Mar 21 2017, 7:17 PM

Polygerrit basically fixes this. Declining because we're not able to fix the issue in the old UI (they're not taking patches to the old UI really now)