category move bug when "from" = "to"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Vladis13
	Jan 24 2025, 9:58 PM

Description

Steps to replicate the issue (include links if applicable):

Let's move the category pages to a category with an identical name: pwb.py category -site:wikisource:ru move -from:"Фёдор Павлович Аделунг" -to:"Фёдор Павлович Аделунг" -inplace

What happens?:
Pages are drop from this category. example1, example1. This bug was discovered during batch processing of a lot of subcategories.

What should have happened instead?:
If the original and target categories are identical, the pages should remain in the category "-to:", the edits should be skipped. Because to remove pages from categories the following options are used: -from:"original category" -to:"".

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[bugfix] ensure that -from and -to arguments are not equal	pywikibot/core	master	+19 -7

Customize query in gerrit

Event Timeline

Vladis13 created this task.Jan 24 2025, 9:58 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 24 2025, 9:58 PM

Xqt triaged this task as High priority.Jan 25 2025, 11:44 AM

Xqt added a project: Pywikibot-category.py.

Vladis13 updated the task description. (Show Details)Feb 5 2025, 10:32 AM

I think the bug is somewhere in category.py _change() → /pywikibot/page/_basepage.py → change_category() subfunction. Maybe on line #2255. Or in pywikibot/textlib.py→ textlib.replaceCategoryInPlace() subfunction on line #1576.
Somewhere there should be a check: if oldcat == newcat: skip.