in page history, for pages with no reviewed revisions, doesn't highlight the unreviewed revisions yellow
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Novem_Linguae
	Jan 25 2025, 11:59 AM

Project Tags

Referenced Files

	F58274111: image.png
	Jan 25 2025, 11:59 AM

	F58274116: image.png
	Jan 25 2025, 11:59 AM

Subscribers

Aklapper

Novem_Linguae

Tacsipacsi

Description

Steps to replicate the issue (include links if applicable):

install FlaggedRevs with default settings
while logged out, create a test page
click on the history tab

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	FlaggedRevsUIHooks: fix yellow highlight in history for new pages	Novem Linguae	mediawiki/extensions/FlaggedRevs	master	+1 -4

Customize query in gerrit

Related Objects

Mentioned In: T384778: No "permanent link" option in sidebar for unreviewed pages in FlaggedRevs

Event Timeline

Novem_Linguae created this task.Jan 25 2025, 11:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2025, 11:59 AM

Change #1114099 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsUIHooks: fix yellow highlight in history for new pages

https://gerrit.wikimedia.org/r/1114099

gerritbot added a project: Patch-For-Review.Jan 25 2025, 12:00 PM

Novem_Linguae renamed this task from in page history, for newly created pages all unreviewed revisions and no reviewed revisions, doesn't highlight the unreviewed revisions yellow to in page history, for pages with no reviewed revisions, doesn't highlight the unreviewed revisions yellow.Jan 25 2025, 12:01 PM

Novem_Linguae mentioned this in T384778: No "permanent link" option in sidebar for unreviewed pages in FlaggedRevs.

What should have happened instead?:

I disagree. An unreviewed page is very different from a page with pending changes: pending changes may be hidden from readers (depending on site configuration), unreviewed pages’ edits are never hidden. So users (on wikis configured that way) may rely on this yellow background and the [pending review] note to find out what readers don’t see.

So I don’t think your patch is a good solution. I don’t want to reject all possible ways to change this without knowing what those ways are, but with my current knowledge, I think this isn’t a bug at all.

Novem_Linguae closed this task as Declined.Mar 25 2025, 6:17 AM

Change #1114099 abandoned by Novem Linguae:

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsUIHooks: fix yellow highlight in history for new pages

Reason:

ticket was declined