Page MenuHomePhabricator

Abuse filter diff uses own (old) styling
Closed, ResolvedPublic

Description

Abuse filter diff uses old styling (yellow/green) but should be using the global diff classes instead (currently orange/blue).


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=34798

Details

Reference
bz36478

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:20 AM
bzimport set Reference to bz36478.
Danny_B created this task.May 3 2012, 12:05 PM

Krinkle, you assigned this to yourself on 2012-07-08, do you still plan to work on it? MatmaRex, you marked it easy, wanna file a patch? :)

Well, it should be pretty easy, just a little boring. Can do.

For the record, this only applies to the diffs between version of filters themselves – the page diffs shown on AbuseFilter special pages use the new styling.

Related URL: https://gerrit.wikimedia.org/r/67868 (Gerrit Change Ie24ad5ac5a9a2bc9b8f0fc0c4a03d5dfe7a6a83f)

Doing this *properly* turned out to be a little tougher, but I think I've got this.

Change 67868 merged by jenkins-bot:
AbuseFilterViewDiff: Make diffs use standard styling (and more)

https://gerrit.wikimedia.org/r/67868

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 29 2016, 7:15 PM