Page MenuHomePhabricator

Update remaining X close buttons
Closed, ResolvedPublic

Assigned To
Authored By
Mazevedo
Jan 27 2025, 4:05 PM
Referenced Files
F62284597: IMG_20EA1EE273D5-1.jpeg
Jun 10 2025, 5:07 PM
F59268300: Screenshot 2025-04-16 at 10.27.50 AM.jpeg
Apr 16 2025, 5:33 PM
F59268296: IMG_6724.PNG
Apr 16 2025, 5:33 PM
F58613939: image.png
Mar 5 2025, 7:18 PM
F58613935: image.png
Mar 5 2025, 7:18 PM
F58613945: image.png
Mar 5 2025, 7:18 PM
F58613932: image.png
Mar 5 2025, 7:18 PM

Description

Address the remaining feedback from this comment, regarding the X close buttons.
https://phabricator.wikimedia.org/T363606#10445694

Those items are not in the navigation bar, so their update requires more work.

Engineering Notes:

Article Reference:

Want: change X -> Done

image.png (1×559 px, 263 KB)

ReferenceViewController -> find and update the close button

Article Gallery:

Want: change X -> Done

image.png (1×559 px, 297 KB)

WMFImageGalleryViewController, find the close button, switch it out so instead of using the image, it uses the localized version of Done (should be in common strings), make sure to delete anything that is now unused.

Article table of contents:

Want: Done label in red box

image.png (2×1 px, 321 KB)

TableOfContentsViewController may be the proper place for this - but feel free to adjust if you think the new Done label belongs elsewhere

Editor Find and replace:

Want: change X -> Done

image.png (1×559 px, 287 KB)

WMFReferencePopoverMessageViewController > go into the storyboard and investigate swapping out this button

Event Timeline

Hello @Anvitha098 I was working on this task but it seems you have removed me.

@Temiloluwa67 hey it looks like you have a lot on your plate
even I started working on this few hours back
let me know if we can split it up

@Temiloluwa67 hey it looks like you have a lot on your plate
even I started working on this few hours back
let me know if we can split it up

Thanks for your response. I dont know if that is possible. maybe we should ask the mentors. but I think there are still other open issues up for grabs @Anvitha098.

Temiloluwa67 changed the task status from Open to In Progress.Mar 19 2025, 12:00 PM
Temiloluwa67 changed the subtype of this task from "Task" to "Feature Request".

Opened up a PR #5227 for this task. Ready for review!

ABorbaWMF subscribed.

There are a couple places where I had some questions.

  1. On iPhone, when viewing a reference, there is now a 'done' button. However, there is also an odd white square above the reference link. It does not appear this way on iPad.
iPhoneiPad
IMG_6724.PNG (2×1 px, 260 KB)
Screenshot 2025-04-16 at 10.27.50 AM.jpeg (2×2 px, 1 MB)

Related to references: on iPhone tapping outside the reference popup, closes the reference. This seem correct, but does not work well on iPad. On iPad tapping outside the reference does not seem to close the reference easily.

  1. On iPad, there is no 'done' button to close the TOC.
QA Notes

(For Toni's latest partail fix):

  • Run the app and tap a reference superscript in article. Ensure the window is now more aligned with the tap target. Note this doesn't fix all the issues Anthony found, but I think this partial improvement is still worth merging.
  • Tap the find in page button and find a bit of text. Ensure the current match background color is brighter than the other matches on the dark and black themes.

The done is now present in all these locations, but I am still seeing the white box in odd places (mentioned above as well).

IMG_20EA1EE273D5-1.jpeg (2×1 px, 511 KB)

HNordeenWMF subscribed.

The done is now present in all these locations, but I am still seeing the white box in odd places (mentioned above as well).

IMG_20EA1EE273D5-1.jpeg (2×1 px, 511 KB)

@ABorbaWMF I can't find a bug task for the off-position-highlighting, could you file one?