Page MenuHomePhabricator
Create Task
Maniphest T384851

PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/filebackend/FileBackend.php(1652)
#0[internal function]MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/filebackend/FileBackend.php(1652)strrpos(null, string)
#2/srv/mediawiki/php-1.44.0-wmf.13/includes/upload/UploadFromChunks.php(173)Wikimedia\FileBackend\FileBackend::extensionFromPath(null)
#3/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiUpload.php(459)UploadFromChunks->concatenateChunks()
#4/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiUpload.php(255)MediaWiki\Api\ApiUpload->getChunkResult(array)
#5/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiUpload.php(172)MediaWiki\Api\ApiUpload->getContextResult()
#6/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(1973)MediaWiki\Api\ApiUpload->execute()
#7/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(941)MediaWiki\Api\ApiMain->executeAction()
#8/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(912)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#9/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#10/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#11/srv/mediawiki/php-1.44.0-wmf.13/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#12/srv/mediawiki/w/api.php(3)require(string)
#13{main}
Impact
Notes
		// Get the file extension from the last chunk
		$ext = FileBackend::extensionFromPath( $this->mVirtualTempPath );
		// Get a 0-byte temp file to perform the concatenation at
		$tmpFile = MediaWikiServices::getInstance()->getTempFSFileFactory()
			->newTempFSFile( 'chunkedupload_', $ext );

$this->mVirtualTempPath is null.

newTempFSFile wants an empty string, not null. I guess on PHP 7.4 FileBackend::extensionFromPath results in a string being returned.

Details

Request URL
https://commons.wikimedia.org/w/api.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)mediawiki/coremaster+1 -1
UploadFromChunks::concatenateChunks: Don't proceed if we don't have a chunk filepath to evaluatemediawiki/coremaster+6 -0
upload: Set UploadFromChunks::mVirtualTempPath on first chunkmediawiki/coremaster+2 -1
FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)mediawiki/coreREL1_43+1 -1
FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)mediawiki/coreREL1_42+1 -1
FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)mediawiki/corewmf/1.44.0-wmf.22+1 -1
FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)mediawiki/coreREL1_39+1 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERRORNoneT384851 PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
· · ·

Event Timeline

Reedy created this task.Jan 27 2025, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2025, 4:21 PM
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Jan 27 2025, 4:22 PM
Reedy added a project: MediaWiki-Uploading.Jan 27 2025, 4:25 PM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Jan 27 2025, 4:29 PM
Reedy added a project: MW-1.43-release.
Reedy updated the task description. (Show Details)Jan 27 2025, 4:50 PM
• mszabo moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Jan 27 2025, 5:02 PM
Krinkle added a project: Unstewarded-production-error.Jan 27 2025, 5:06 PM
Krinkle subscribed.

Tagging Unstewarded-production-error since MediaWiki-Uploading is unassigned on mw:Maintainers.

Scott_French subscribed.Jan 27 2025, 5:39 PM
Reedy added a comment.Jan 27 2025, 6:38 PM

It would look like this in theory happens every time for the first chunk...

In this case, the file is probably small enough that it's just one chunk

Reedy added a project: PHP 8.1 support.Jan 27 2025, 8:02 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Jan 27 2025, 8:06 PM
gerritbot added a comment.Jan 27 2025, 8:13 PM

Change #1114455 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] UploadFromChunks::concatenateChunks: Don't proceed if we don't have a chunk filepath to evaluate

https://gerrit.wikimedia.org/r/1114455

gerritbot added a project: Patch-For-Review.Jan 27 2025, 8:13 PM
Reedy added a comment.Jan 28 2025, 9:04 PM

I'm guessing https://gerrit.wikimedia.org/r/1086000 was an attempted fix for this issue too

Reedy merged a task: T385256: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated.Jan 31 2025, 12:09 PM
Reedy added a subscriber: Ammarpad.
Maintenance_bot added a project: Commons.Jan 31 2025, 12:30 PM
Reedy changed the task status from Open to In Progress.Jan 31 2025, 1:08 PM
Alex44019 subscribed.Feb 7 2025, 8:55 AM
Scott_French added a comment.Mar 12 2025, 10:27 PM

Adding a fresh example for the convenience of working gerrit links. While not the only remaining deprecation warning on 8.1, it is by far the dominant one.

Also +1 to @Reedy's analysis in T384851#10498339 that this seems like it would happen on a single-chunk upload? (i.e., we get into concatenateChunks without ever having ended up in continueChunks, which would have initialized $this->mVirtualTempPath).

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.20/includes/libs/filebackend/FileBackend.php(1652)
#0[internal function]MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.20/includes/libs/filebackend/FileBackend.php(1652)strrpos(null, string)
#2/srv/mediawiki/php-1.44.0-wmf.20/includes/upload/UploadFromChunks.php(173)Wikimedia\FileBackend\FileBackend::extensionFromPath(null)
#3/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiUpload.php(459)UploadFromChunks->concatenateChunks()
#4/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiUpload.php(255)MediaWiki\Api\ApiUpload->getChunkResult(array)
#5/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiUpload.php(172)MediaWiki\Api\ApiUpload->getContextResult()
#6/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiMain.php(2005)MediaWiki\Api\ApiUpload->execute()
#7/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#8/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#9/srv/mediawiki/php-1.44.0-wmf.20/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#10/srv/mediawiki/php-1.44.0-wmf.20/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#11/srv/mediawiki/php-1.44.0-wmf.20/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#12/srv/mediawiki/w/api.php(3)require(string)
#13{main}
Reedy added a comment.Mar 12 2025, 11:10 PM
In T384851#10631056, @Scott_French wrote:

Also +1 to @Reedy's analysis in T384851#10498339 that this seems like it would happen on a single-chunk upload? (i.e., we get into concatenateChunks without ever having ended up in continueChunks, which would have initialized $this->mVirtualTempPath).

I have to wonder if bailing out with an error as in the proposed patch will in theory make things worse, breaking uploads that otherwise work (even if creating logspam invisible to users)...

Scott_French added a comment.EditedMar 12 2025, 11:49 PM
In T384851#10631172, @Reedy wrote:

I have to wonder if bailing out with an error as in the proposed patch will in theory make things worse, breaking uploads that otherwise work (even if creating logspam invisible to users)...

Agreed, yeah - from a quick look at the logs from one recent example request, it seems like these indeed work? https://logstash.wikimedia.org/goto/aa261c6db84c14f1c846f2d024c368b9

That example also seems to corroborate the single-chunk theory.

Of course, it might be that there's something subtle I'm missing about the motivation for carrying over the extension to the TempFSFile name ... In any case, it seems like it works with extensionFromPath having returned empty string, as it has previously under 7.4 (just silently).

Reedy triaged this task as High priority.Mar 13 2025, 10:28 PM
In T384851#10502366, @Reedy wrote:

I'm guessing https://gerrit.wikimedia.org/r/1086000 was an attempted fix for this issue too

^ I wonder if that is potentially a reasonable fix...

gerritbot added a comment.Mar 13 2025, 10:30 PM

Change #1086000 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@master] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1086000

Scott_French added a comment.Mar 14 2025, 9:11 PM

Agreed that https://gerrit.wikimedia.org/r/1086000 is probably a reasonable fix for the deprecation warning, as it maintains the existing behavior if $path is indeed null (returns empty string).

Other options that come to mind:

If it does somehow matter that the TempFSFile into which we concatenate has the same extension as $this->mVirtualTempPath, then we could presumably special-case $chunkIndex === 0 in concatenateChunks to initialize it - e.g., insert the "missing" call to $this->getChunkStatus(). Alternatively, I guess we could avoid the DB query by using $this->mStashFile->getPath() in this first-and-only-chunk case, which I think ends up with the same extension (i.e., as the us_path column in uploadstash).

If it doesn't matter, and I have a hard time imagining how it could given that single-chunk uploads have $ext empty and that seems to be fine (it's just that we're only now learning this is the case thanks to deprecation warnings), maybe we can skip the dependency on $this->mVirtualTempPath entirely?

dancy subscribed.Mar 31 2025, 6:55 PM

I'm on train duty this week and wanted to note that this error has been persistent for a couple of months and is currently the second most frequent in logspam-watch output.

gerritbot added a comment.Mar 31 2025, 7:19 PM

Change #1086000 merged by jenkins-bot:

[mediawiki/core@master] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1086000

gerritbot added a comment.Mar 31 2025, 7:20 PM

Change #1132734 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@REL1_43] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132734

gerritbot added a comment.Mar 31 2025, 7:20 PM

Change #1132735 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@REL1_42] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132735

gerritbot added a comment.Mar 31 2025, 7:20 PM

Change #1132736 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@REL1_39] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132736

gerritbot added a comment.Mar 31 2025, 7:20 PM

Change #1132737 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@wmf/1.44.0-wmf.22] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132737

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 31 2025, 8:00 PM
gerritbot added a comment.Mar 31 2025, 9:18 PM

Change #1132736 merged by jenkins-bot:

[mediawiki/core@REL1_39] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132736

gerritbot added a comment.Mar 31 2025, 9:21 PM

Change #1132735 merged by jenkins-bot:

[mediawiki/core@REL1_42] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132735

gerritbot added a comment.Mar 31 2025, 9:22 PM

Change #1132734 merged by jenkins-bot:

[mediawiki/core@REL1_43] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132734

gerritbot added a comment.Mar 31 2025, 9:22 PM

Change #1132737 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.22] FileBackend: PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack)

https://gerrit.wikimedia.org/r/1132737

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), MW-1.39-notes, MW-1.42-notes, MW-1.43-notes; removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 31 2025, 10:00 PM
Stashbot added a comment.Mar 31 2025, 10:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-31T22:13:48Z] <reedy@deploy1003> Synchronized php-1.44.0-wmf.22/includes/libs/filebackend/FileBackend.php: T384851 (duration: 02m 14s)

Reedy lowered the priority of this task from High to Medium.Mar 31 2025, 10:14 PM
Jdforrester-WMF subscribed.Apr 7 2025, 8:28 PM

Last log entry was on Mar 31, 2025 @ 21:50:35.374, so I think this worked. Shall we call this Resolved?

gerritbot added a comment.Apr 7 2025, 8:51 PM

Change #1134760 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] upload: Set UploadFromChunks::mVirtualTempPath on first chunk

https://gerrit.wikimedia.org/r/1134760

Reedy moved this task from Blocker to Not a blocker on the MW-1.43-release board.Apr 10 2025, 6:47 PM
gerritbot added a comment.Apr 17 2025, 2:24 PM

Change #1134760 merged by jenkins-bot:

[mediawiki/core@master] upload: Set UploadFromChunks::mVirtualTempPath on first chunk

https://gerrit.wikimedia.org/r/1134760

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.27; 2025-04-29); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Apr 17 2025, 3:00 PM
gerritbot added a comment.Apr 17 2025, 6:11 PM

Change #1114455 abandoned by Umherirrender:

[mediawiki/core@master] UploadFromChunks::concatenateChunks: Don't proceed if we don't have a chunk filepath to evaluate

Reason:

Fixed via I27516ce6ce10793a748475338a2810537f4cb223

https://gerrit.wikimedia.org/r/1114455

Umherirrender closed this task as Resolved.Apr 17 2025, 6:13 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender subscribed.

No further backport needed, as 1a4d7d410c527f6a9f57b5c3e6f733a4a64f41c1 is enough to avoid the deprecation warning, without breaking the action.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits