PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Jan 27 2025, 4:31 PM

Description

Error

mwversion: 1.44.0-wmf.13
reqId: bbcf2edb-7ecb-4a57-beee-71f1fbe00ec9
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/LicenseParser.php(89)
#0	[internal function]	MWExceptionHandler::handleError(int, string, string, int)
#1	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/LicenseParser.php(89)	trim(null)
#2	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/LicenseParser.php(38)	CommonsMetadata\LicenseParser->parseCreativeCommonsLicenseString(null)
#3	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/LicenseParser.php(55)	CommonsMetadata\LicenseParser->parseLicenseString(null)
#4	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/DataCollector.php(426)	CommonsMetadata\LicenseParser->sortDataByLicensePriority(array, Closure)
#5	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/DataCollector.php(218)	CommonsMetadata\DataCollector->selectLicense(array)
#6	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/DataCollector.php(108)	CommonsMetadata\DataCollector->getTemplateMetadata(array)
#7	/srv/mediawiki/php-1.44.0-wmf.13/extensions/CommonsMetadata/src/HookHandler.php(84)	CommonsMetadata\DataCollector->collect(array, LocalFile)
#8	/srv/mediawiki/php-1.44.0-wmf.13/includes/HookContainer/HookContainer.php(155)	CommonsMetadata\HookHandler->onGetExtendedMetadata(array, LocalFile, MediaWiki\Context\RequestContext, bool, int)
#9	/srv/mediawiki/php-1.44.0-wmf.13/includes/HookContainer/HookRunner.php(1895)	MediaWiki\HookContainer\HookContainer->run(string, array)
#10	/srv/mediawiki/php-1.44.0-wmf.13/includes/media/FormatMetadata.php(1787)	MediaWiki\HookContainer\HookRunner->onGetExtendedMetadata(array, LocalFile, MediaWiki\Context\RequestContext, bool, int)
#11	/srv/mediawiki/php-1.44.0-wmf.13/includes/media/FormatMetadata.php(1708)	FormatMetadata->getExtendedMetadataFromHook(LocalFile, array, int)
#12	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiQueryImageInfo.php(652)	FormatMetadata->fetchExtendedMetadata(LocalFile)
#13	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiQueryImageInfo.php(238)	MediaWiki\Api\ApiQueryImageInfo::getInfo(LocalFile, array, MediaWiki\Api\ApiResult, array, array)
#14	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiQuery.php(727)	MediaWiki\Api\ApiQueryImageInfo->execute()
#15	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(1973)	MediaWiki\Api\ApiQuery->execute()
#16	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(941)	MediaWiki\Api\ApiMain->executeAction()
#17	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(912)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#18	/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#19	/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Api\ApiEntryPoint->execute()
#20	/srv/mediawiki/php-1.44.0-wmf.13/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#21	/srv/mediawiki/w/api.php(3)	require(string)
#22	{main}

Impact

Notes

Details

Request URL: https://ml.wikipedia.org/w/api.php?action=query&format=*&formatversion=*&iiprop=*&iiurlheight=*&iiurlwidth=*&prop=*&titles=*

Subject	Repo	Branch	Lines +/-
LicenseParser: Avoid passing null to string functions	mediawiki/extensions/CommonsMetadata	wmf/1.44.0-wmf.13	+18 -25
LicenseParser: Avoid passing null to string functions	mediawiki/extensions/CommonsMetadata	REL1_43	+18 -25
LicenseParser: Avoid passing null to string functions	mediawiki/extensions/CommonsMetadata	REL1_42	+18 -25
LicenseParser: Avoid passing null to string functions	mediawiki/extensions/CommonsMetadata	REL1_39	+18 -25
LicenseParser: Avoid passing null to string functions	mediawiki/extensions/CommonsMetadata	master	+18 -25

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T358667 Drop PHP 8.2 support from MediaWiki
Stalled		None	T360995 Migrate Wikimedia production from PHP 8.1 to PHP 8.3
Open		None	T363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
Stalled		None	T255792 Quibble runs core:unit tests twice!
Open		None	T328919 Upgrade to PHPUnit 10
Open		None	T376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
Open		None	T379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Open		None	T378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Open		None	T358666 Drop PHP 8.1 support from MediaWiki
Open		None	T380185 Prepare for newer geoip2/geoip2 library
Open		None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Stalled		None	T373753 Drop symfony/polyfill-php80 and symfony/polyfill-php81 from mediawiki-vendor
Open		None	T379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled		None	T334726 Use return type `never` in Wikibase
Open		None	T328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
Stalled		None	T319055 Upgrade to psr/container 2.x
In Progress		Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
In Progress		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	mszabo	T384853 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

Event Timeline

Reedy created this task.Jan 27 2025, 4:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2025, 4:31 PM

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Jan 27 2025, 4:31 PM

Reedy mentioned this in T384854: PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated.Jan 27 2025, 4:41 PM

Reedy updated the task description. (Show Details)

Change #1114421 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CommonsMetadata@master] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114421

gerritbot added a project: Patch-For-Review.Jan 27 2025, 4:57 PM

mszabo moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Jan 27 2025, 5:02 PM

Krinkle added a project: Structured Data Engineering.Jan 27 2025, 5:07 PM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJan 27 2025, 5:07 PM

Change #1114421 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@master] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114421

Scott_French subscribed.Jan 27 2025, 5:40 PM

Change #1114428 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/CommonsMetadata@REL1_43] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114428

Change #1114429 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/CommonsMetadata@REL1_42] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114429

Change #1114430 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/CommonsMetadata@REL1_39] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114430

Reedy closed this task as Resolved.Jan 27 2025, 5:41 PM

Reedy assigned this task to mszabo.

Change #1114430 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@REL1_39] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114430

Change #1114429 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@REL1_42] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114429

Change #1114428 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@REL1_43] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114428

Change #1114435 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/CommonsMetadata@wmf/1.44.0-wmf.13] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114435

Change #1114435 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@wmf/1.44.0-wmf.13] LicenseParser: Avoid passing null to string functions

https://gerrit.wikimedia.org/r/1114435

Mentioned in SAL (#wikimedia-operations) [2025-01-27T18:16:43Z] <reedy@deploy2002> Synchronized php-1.44.0-wmf.13/extensions/CommonsMetadata/: T384853 T384854 (duration: 10m 45s)

Reedy added a project: PHP 8.1 support.Jan 27 2025, 8:02 PM

Reedy removed a project: Patch-For-Review.Jan 29 2025, 1:46 PM

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecatedClosed, ResolvedPublicPRODUCTION ERRORActions