Page MenuHomePhabricator

Add ScopedTypeaheadSearch Vue component when the flag is enabled
Closed, ResolvedPublic

Description

When a feature flag is enabled, a user should see, and be able to use ScopedTypeaheadSearch to find different kinds of entities on Wikidata.

Prerequisites:

  • feature flag already exists ($wgWBRepoSettings['tmpEnableScopedTypeaheadSearch']) (T384735)
  • there is a visually-identical CSS-only version of scoped search that the Vue component can be mounted to (T384943)
  • there is a working prototype of the ScopedTypeaheadSearch component (T384730)

Acceptance Criteria

  • when $wgWBRepoSettings['enableEntitySearchUI'] and $wgWBRepoSettings['tmpEnableScopedTypeaheadSearch'] are enabled, interacting with the search causes the ScopedTypeaheadSearch Vue component to mount. It seemlessly takes the place of the CSS-only version
  • styling is identical to the CSS-only version from T384943
  • the component is fully usable via keyboard
  • The component has the functionality worked out in the standalone prototype (T384730)
    • All entity types are listed in the Select dropdown
    • TypeaheadSearch suggestions are limited by the selected scope
    • Typing a prefix updates the selected scope, and scopes the search
    • Selecting a different scope after typing a prefix overrides the prefix scope. The prefix is then treated as plain input text
    • clicking one of the suggestions loads the page for that entity

Event Timeline

AudreyPenven_WMDE renamed this task from Replace TypeaheadSearch with ScopedTypeaheadSearch on Wikidata.org to Add ScopedTypeaheadSearch Vue component when the flag is enabled.Jan 30 2025, 5:08 PM
AudreyPenven_WMDE updated the task description. (Show Details)

potentially use patchdemo as a method to verify the result of this

Change #1118819 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add ScopedTypeahead Vue component

https://gerrit.wikimedia.org/r/1118819

Change #1119101 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [DNM] Set scoped typeahead search on by default (for patchdemo)

https://gerrit.wikimedia.org/r/1119101

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/d98a3dd59e/w/

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/e4bb62d0a4/w/

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/d98a3dd59e/w/

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/22cac51637/w/

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/e4bb62d0a4/w/

Removed LTR support from acceptance criteria since that is now covered in T385789

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/2dfe9857c0/w/

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/22cac51637/w/

Change #1118819 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add ScopedTypeahead Vue component

https://gerrit.wikimedia.org/r/1118819

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/a5ddef352e/w/

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/2dfe9857c0/w/

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/a5ddef352e/w/

Test wiki created on Patch demo by Audrey Penven (WMDE) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/6d739dee65/w/

Test wiki on Patch demo by Audrey Penven (WMDE) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/6d739dee65/w/

Test wiki created on Patch demo by Audrey Penven (WMDE) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/9e5925d92a/w/

Change #1119101 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] [DNM] Set scoped typeahead search on by default (for patchdemo)

Reason:

no longer needed

https://gerrit.wikimedia.org/r/1119101