Page MenuHomePhabricator

Error 1969 from MediaWiki\Extension\Nuke\SpecialNuke::getNewPages, {error} {sql1line} {db_server}
Closed, ResolvedPublicPRODUCTION ERROR

Description

Leaving in QA for now. I was still able to create a DB timeout error when doing a title query with the 90 day limit; the initial query threw the error, but subsequent queries worked, presumably due to caching; We should retest again with a cold cache at 60 and 30 days to verify if the error is due to the longer timespan. We realized that we didn't actually have a known error free result before expanding the time range.

It is possible to perform title queries that result in a database timeout, however, the behavior is the same at 60 and 30 days. This means the issue was already there and is not a regression from this task. Will file a bug report and mention this task before closing.

Steps to replicate the issue (include links if applicable):

What happens?:
Database error

image.png (368×756 px, 28 KB)

Error
normalized_message
Error 1969 from MediaWiki\Extension\Nuke\SpecialNuke::getNewPages, {error} {sql1line} {db_server}
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/Database.php(1211)
#0/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/Database.php(1188)Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, int, string, string)
#1/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/Database.php(647)Wikimedia\Rdbms\Database->reportQueryError(string, int, string, string, bool)
#2/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/Database.php(1365)Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#3/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/DBConnRef.php(127)Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/database/DBConnRef.php(351)Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(762)Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6/srv/mediawiki/php-1.44.0-wmf.13/extensions/Nuke/includes/SpecialNuke.php(521)Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
#7/srv/mediawiki/php-1.44.0-wmf.13/extensions/Nuke/includes/SpecialNuke.php(386)MediaWiki\Extension\Nuke\SpecialNuke->getNewPages(MediaWiki\Extension\Nuke\NukeContext, array)
#8/srv/mediawiki/php-1.44.0-wmf.13/extensions/Nuke/includes/SpecialNuke.php(180)MediaWiki\Extension\Nuke\SpecialNuke->showListForm(MediaWiki\Extension\Nuke\NukeContext)
#9/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/SpecialPage.php(729)MediaWiki\Extension\Nuke\SpecialNuke->execute(null)
#10/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/SpecialPageFactory.php(1735)MediaWiki\SpecialPage\SpecialPage->run(null)
#11/srv/mediawiki/php-1.44.0-wmf.13/includes/actions/ActionEntryPoint.php(503)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#12/srv/mediawiki/php-1.44.0-wmf.13/includes/actions/ActionEntryPoint.php(145)MediaWiki\Actions\ActionEntryPoint->performRequest()
#13/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#14/srv/mediawiki/php-1.44.0-wmf.13/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/index.php(3)require(string)
#16{main}
Impact

certain enwiki Special:Nuke page title queries can't be run because they regularly exceed the query execution limit

Notes

You must have the massdelete privilege to view the page, but the query can be examined in logstash and run from a stathost for testing

Details

Request URL
https://en.wikipedia.org/wiki/Special:Nuke
Related Changes in Gerrit:

Event Timeline

Change #1253428 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/Nuke@master] Reject page title patterns with leading '%' wildcard

https://gerrit.wikimedia.org/r/1253428

Arendpieter changed the task status from Open to In Progress.Mon, Mar 16, 11:06 AM
jsn.sherman moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

@Arendpieter thanks for picking this up! I've put it in our review queue.

Change #1253428 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Reject page title patterns with leading '%' wildcard

https://gerrit.wikimedia.org/r/1253428

neriah assigned this task to Arecaquaetias.