Some LogEventsList::showLogExtract() callers need to be updated for multiblocks.
Code review
IntroMessageBuilder::addUserWarnings(), Article::showMissingArticle() and ContributionsSpecialPage::contributionsSub() all show a block log snippet if the relevant user is blocked.
IntroMessageBuilder and showMissingArticle are apparently identical, and suppress display of partial blocks as described in T203171. Whereas contributionsSub tries to show a bit more information in its wrapper message about the kind of block and the kind of user, requiring 4 messages.
All use a limit of 1. For multiblocks, we would like to show log entries for all active blocks.
All are conditional on a "vague target" block query, so a range block relevant to the viewed single IP address will be loaded. The log snippet query uses the target of the loaded block, so it shows a range block snippet.
You might think that IntroMessageBuilder on a user talk page would warn the editor that the user can't reply. But the feature has never been useful for that. For a sitewide block, applicability to the talk page is not checked.
Implementation options
Option 1: Load all active blocks for the user, and show all log entries for those blocks by joining on log_search. Modify existing messages to not specify the number of blocks or entries. The user is considered to be partially blocked if all blocks are partial.
- Simple
- Shows both the initial block action and any reblocks, since reblocks have the same block ID.
- https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1116897
Option 1.1: Suppress log entry proliferation due to reblocks using SQL magic
Option 2: Load all active blocks for the user, and retain current behaviour if there is only one block. Use new messages and log_search behaviour if there is more than one block.
- Adds 3 messages
- Shows both the initial block and any reblocks if there are multiple blocks.
- https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1116899
Option 2.1: As for option 2 but suppress log entry proliferation using SQL magic as in option 1.1
Option 3: Show only one log entry but vary the wrapper messages to tell the user that there are multiple blocks. Note the "view full log" link which is pre-existing.
Option 4: Show a BlockListPager table instead of a log snippet
Design as implemented
- Option 3
- Show missing and edit intro have Special:BlockList link
