Page MenuHomePhabricator

Nuke's help text for the different MaxAge ranges is confusing
Closed, ResolvedPublicBUG REPORT

Description

Our current help text, on the SQL LIKE query, implies that this filter determines 30 days vs 90 days. But it's actually the use of the Username/IP address filter which does. Additionally, there's no UI element clarifying the 90 day limit. We could position this help text better to clarify this for users.

Original task

Steps to replicate the issue (include links if applicable):

  • Navigate to Special:Nuke.
  • Filter by namespace Main and dates where you know you will get results
  • Press List Pages

What happens?:
Unexpected pages show up and it doesn't respect the limit (500 pages). There are missing pages in the query.

What should have happened instead?:
When filtered by any user name with the same conditions, pages show up. With the target filter blank, all pages created by all users should show up.

Other information (browser name/version, screenshots, etc.):

Results show up when we filter by user.

Screenshot 2025-01-28 at 13.20.34.png (796×1 px, 155 KB)

Same query, no user; no results

Screenshot 2025-01-28 at 13.20.45.png (605×984 px, 60 KB)

Related Objects

Event Timeline

Scardenasmolinar triaged this task as High priority.

These two queries are using different tables (revision for the query with a user, recentchanges for the query without). So this is affected by the value of $wgNukeMaxAge and $wgRCMaxAge. Are the pages found in the first screenshot newer than $wgNukeMaxAge but older than $wgRCMaxAge? Because in that case, this would be expected behavior.

It's worth noting that there's currently no warning message for when the user provides a date range that falls outside of $wgRCMaxAge and no target (which forces use of the recentchanges table).

These two queries are using different tables (revision for the query with a user, recentchanges for the query without). So this is affected by the value of $wgNukeMaxAge and $wgRCMaxAge. Are the pages found in the first screenshot newer than $wgNukeMaxAge but older than $wgRCMaxAge? Because in that case, this would be expected behavior.

It's worth noting that there's currently no warning message for when the user provides a date range that falls outside of $wgRCMaxAge and no target (which forces use of the recentchanges table).

Got it. I think I know what happened here. I increased $wgNukeMaxAge and $wgRCMaxAge in my local environment, but the recent changes table had probably already deleted the information. It would be a good idea to add a note to explain when the recent changes table is used and when the revision table is used. Otherwise, admins will be expecting different results like we did. I'm going to leave the task open for now, but will probably mark it as Invalid later on.

Chlod changed the task status from Open to In Progress.EditedJan 29 2025, 7:25 AM
Chlod moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Using this task as a reference for adding in the warning that the date added is before $wgRCMaxAge. Will move it forward in a bit. As for a note on which table is being used, that's probably something for another time (since, as a UI thing, it should probably be something to run by Design).

Chlod changed the task status from In Progress to Open.Jan 29 2025, 7:28 AM
Chlod moved this task from In Progress to Ready on the Moderator-Tools-Team (Kanban) board.

Actually, on second thought, a warning for this probably also needs to go through Design, as I can't think of a satisfying way to word/display the fact that the actual minimum date being followed is smaller than what the user provided.

Scardenasmolinar lowered the priority of this task from High to Medium.Jan 30 2025, 2:19 PM
jsn.sherman changed the task status from Open to Stalled.Jan 30 2025, 2:19 PM
jsn.sherman added subscribers: OTichonova, jsn.sherman.

@OTichonova This is something we'll need your help with when you are available

jsn.sherman added a subscriber: Chlod.

@Scardenasmolinar suggested adjusting the "from date" to align with the max age based on the query used for the given filter combination.

jsn.sherman changed the task status from Stalled to In Progress.Jan 30 2025, 5:39 PM

We discussed this at length as a team and @OTichonova is going to help out the poor engineers by providing some mockups of the different options we discussed.

Samwalton9-WMF renamed this task from Nuke filter dates are not returning correct results to Nuke's help text for the different MaxAge ranges is confusing.Feb 4 2025, 3:54 PM
Samwalton9-WMF updated the task description. (Show Details)

Hi @Scardenasmolinar!
As discussed below is the new design (Figma).

Summary of changes:

  • No more default dates
  • No more description text under the SQL pattern filter.
  • New 'Date range' header with a description text: "If a username or IP address is provided, pages up to 90 days old can be retrieved. Otherwise, for performance reasons, pages up to 30 days old can be retrieved."
  • For Codex: The new 'Date range' header is bolded with a description text below it. The "from" and "to" date input fields will be inside a border (with header text unbolded).
New design
Date.png (1×1 px, 72 KB)
Kgraessle changed the task status from In Progress to Stalled.Feb 6 2025, 8:15 PM
Kgraessle added a subscriber: Samwalton9-WMF.

@OTichonova @Samwalton9-WMF since the new designs are using codex, I wonder if it would make sense to work on this ticket after T153988: Migrate Special:Nuke to Codex?

Kgraessle changed the task status from Stalled to Open.Feb 7 2025, 5:08 PM

Change #1118177 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/Nuke@master] Nuke's help text for the different MaxAge ranges is confusing

https://gerrit.wikimedia.org/r/1118177

Hi @Scardenasmolinar!
As discussed below is the new design (Figma).

Summary of changes:

  • No more default dates
  • No more description text under the SQL pattern filter.
  • New 'Date range' header with a description text: "If a username or IP address is provided, pages up to 90 days old can be retrieved. Otherwise, for performance reasons, pages up to 30 days old can be retrieved."
  • For Codex: The new 'Date range' header is bolded with a description text below it. The "from" and "to" date input fields will be inside a border (with header text unbolded).
New design
Date.png (1×1 px, 72 KB)

@OTichonova for the Date range description text, is this always visible or only when the nuke max age is different than the recent changes max age?

@OTichonova for the Date range description text, is this always visible or only when the nuke max age is different than the recent changes max age?

Hi @Kgraessle! It is always visible.

@OTichonova for the Date range description text, is this always visible or only when the nuke max age is different than the recent changes max age?

Hi @Kgraessle! It is always visible.

Thanks!

@OTichonova Sorry, one more question for you.

If the date ranges are the same (this can happen on some wikis) it shows like this:

Screenshot 2025-02-11 at 1.24.26 PM.png (875×974 px, 102 KB)

Is this ok?

Hi @Kgraessle! Sorry, so in the case where it is the same we should have the text copy be:
"Due to performance reasons, pages up to $wgNukeMaxAge days old can be retrieved."

And have the longer text appear only when there is a difference between the ranges.

Change #1118177 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Nuke's help text for the different MaxAge ranges is confusing

https://gerrit.wikimedia.org/r/1118177

Putting this back to ready per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Nuke/+/1118177 comments about adding plural message handling.

Kgraessle subscribed.
Scardenasmolinar changed the task status from Open to In Progress.Feb 26 2025, 12:41 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change #1123049 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/Nuke@master] Add PLURAL to Nuke messages

https://gerrit.wikimedia.org/r/1123049

Change #1123049 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Add PLURAL to Nuke messages

https://gerrit.wikimedia.org/r/1123049

Verified working on testwiki; leaving open until train finishes rolling out.