Page MenuHomePhabricator
Create Task
Maniphest T384963

PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Parsers/DateFormatParser.php(144)
#0[internal function]MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Parsers/DateFormatParser.php(144)strlen(null)
#2/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Parsers/DateFormatParser.php(348)Wikibase\Repo\Parsers\DateFormatParser->parseDateFormat(null)
#3/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Parsers/DateFormatParser.php(76)Wikibase\Repo\Parsers\DateFormatParser->parseDate(string)
#4/srv/mediawiki/php-1.44.0-wmf.13/vendor/data-values/common/src/ValueParsers/StringValueParser.php(47)Wikibase\Repo\Parsers\DateFormatParser->stringParse(string)
#5/srv/mediawiki/php-1.44.0-wmf.13/vendor/data-values/common/src/ValueParsers/DispatchingValueParser.php(60)ValueParsers\StringValueParser->parse(string)
#6/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Api/ParseValue.php(264)ValueParsers\DispatchingValueParser->parse(string)
#7/srv/mediawiki/php-1.44.0-wmf.13/extensions/Wikibase/repo/includes/Api/ParseValue.php(160)Wikibase\Repo\Api\ParseValue->parseStringValue(ValueParsers\DispatchingValueParser, string, null)
#8/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(1973)Wikibase\Repo\Api\ParseValue->execute()
#9/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(941)MediaWiki\Api\ApiMain->executeAction()
#10/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiMain.php(912)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#11/srv/mediawiki/php-1.44.0-wmf.13/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#12/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#13/srv/mediawiki/php-1.44.0-wmf.13/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#14/srv/mediawiki/w/api.php(3)require(string)
#15{main}
Impact
Notes

Details

Request URL
https://www.wikidata.org/w/api.php?action=wbparsevalue&errorformat=*&format=*&options=*&parser=*&uselang=*&values=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/WikibaseREL1_39+3 -1
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/WikibaseREL1_42+3 -1
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/WikibaseREL1_43+3 -1
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/Wikibasewmf/1.44.0-wmf.14+3 -1
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/Wikibasewmf/1.44.0-wmf.13+3 -1
Handle null date format in MwDateFormatParserFactorymediawiki/extensions/Wikibasemaster+3 -1
Add monthonly date format to MessagesNn.phpmediawiki/coremaster+8 -4
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERRORNoneT384963 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
· · ·

Event Timeline

Reedy created this task.Jan 28 2025, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2025, 7:28 PM
Reedy added projects: wmde-wikidata-tech, MediaWiki-extensions-Wikibase-Repo.Jan 28 2025, 7:29 PM
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.
Scott_French subscribed.Jan 28 2025, 7:34 PM
• mszabo moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Jan 28 2025, 8:25 PM
• mszabo subscribed.Jan 28 2025, 9:54 PM

This might not be a Wikibase bug but rather a Language bug where getDateFormatString returns null for certain input combinations.

The request where the notice occurred requested parsing in Japanese, so I created a script to figure out what combinations might be failing:

		$ja = MediaWikiServices::getInstance()->getLanguageFactory()->getLanguage( 'ja' );
		$opts = ArrayUtils::cartesianProduct( [ 'time', 'date', 'monthonly', 'both', 'pretty' ], [ 'mdy', 'dmy', 'ymd', 'ISO 8601', 'default' ] );
		foreach ( $opts as [ $type, $pref ] ) {
			$str = $ja->getDateFormatString( $type, $pref );
			if ( $str === null ) {
				var_dump( $type );
				var_dump( $pref );
				break;
			}
		}

which gives monthonly + default.

• mszabo added a subscriber: matmarex.Jan 28 2025, 10:03 PM

Looks like @matmarex foresaw exactly this failure mode in code review comments when the monthonly date format was added 12 years ago: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/77059. The issue here specifically seems to be that the default date format for Japanese is ja, so the EN fallback looks for ja monthonly which of course won't be defined among English date formats.

I suppose the ultimate fix here would be to add appropriate monthonly dateformats for each language.

• mszabo added a project: MediaWiki-Internationalization.Jan 28 2025, 10:04 PM
• mszabo mentioned this in T384867: PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated.Jan 28 2025, 10:07 PM
• mszabo added a comment.Jan 28 2025, 10:17 PM

Looks like this combination is broken in 66 languages (as reported by

brokenLangs.php817 BDownload
):

ami: monthonly default is broken
blk: monthonly default is broken
ce: monthonly default is broken
cpx: monthonly default is broken
cpx-hans: monthonly default is broken
cpx-hant: monthonly default is broken
cs: monthonly default is broken
fi: monthonly default is broken
fit: monthonly default is broken
fy: monthonly default is broken
gan: monthonly default is broken
gan-hans: monthonly default is broken
gan-hant: monthonly default is broken
hak: monthonly default is broken
hr: monthonly default is broken
hsn: monthonly default is broken
ii: monthonly default is broken
is: monthonly default is broken
ja: monthonly default is broken
kjp: monthonly default is broken
km: monthonly default is broken
ko: monthonly default is broken
ko-kp: monthonly default is broken
krl: monthonly default is broken
ksw: monthonly default is broken
lzh: monthonly default is broken
mnw: monthonly default is broken
my: monthonly default is broken
nan: monthonly default is broken
nn: monthonly default is broken
oc: monthonly default is broken
olo: monthonly default is broken
pnt: monthonly default is broken
pwn: monthonly default is broken
rki: monthonly default is broken
rsk: monthonly default is broken
sl: monthonly default is broken
sr: monthonly default is broken
sr-ec: monthonly default is broken
sr-el: monthonly default is broken
szy: monthonly default is broken
tay: monthonly default is broken
th: monthonly default is broken
trv: monthonly default is broken
vi: monthonly default is broken
vo: monthonly default is broken
vot: monthonly default is broken
wuu: monthonly default is broken
wuu-hans: monthonly default is broken
wuu-hant: monthonly default is broken
yue: monthonly default is broken
yue-hans: monthonly default is broken
yue-hant: monthonly default is broken
za: monthonly default is broken
zh: monthonly default is broken
zh-classical: monthonly default is broken
zh-cn: monthonly default is broken
zh-hans: monthonly default is broken
zh-hant: monthonly default is broken
zh-hk: monthonly default is broken
zh-min-nan: monthonly default is broken
zh-mo: monthonly default is broken
zh-my: monthonly default is broken
zh-sg: monthonly default is broken
zh-tw: monthonly default is broken
zh-yue: monthonly default is broken
Total broken: 66
gerritbot added a comment.Jan 29 2025, 9:34 AM

Change #1114958 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/core@master] Add monthonly date format to MessagesNn.php

https://gerrit.wikimedia.org/r/1114958

gerritbot added a project: Patch-For-Review.Jan 29 2025, 9:34 AM
gerritbot added a comment.Jan 29 2025, 10:26 AM

Change #1114958 merged by jenkins-bot:

[mediawiki/core@master] Add monthonly date format to MessagesNn.php

https://gerrit.wikimedia.org/r/1114958

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 29 2025, 11:00 AM
Lucas_Werkmeister_WMDE added a project: [Archived]Wikidata Dev Team (Wikidata.org Slice).Jan 29 2025, 12:14 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Jan 29 2025, 12:31 PM

Change #1114993 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1114993

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jan 29 2025, 12:31 PM
ArthurTaylor claimed this task.Jan 29 2025, 1:05 PM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 29 2025, 1:07 PM
ArthurTaylor moved this task from In Peer Review to Waiting for Deployment Window on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
gerritbot added a comment.Jan 29 2025, 1:34 PM

Change #1114993 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1114993

gerritbot added a comment.Jan 29 2025, 1:42 PM

Change #1115010 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.14] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115010

gerritbot added a comment.Jan 29 2025, 1:42 PM

Change #1115012 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.13] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115012

gerritbot added a comment.Jan 29 2025, 2:33 PM

Change #1115012 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.13] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115012

gerritbot added a comment.Jan 29 2025, 2:33 PM

Change #1115010 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.14] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115010

Lucas_Werkmeister_WMDE subscribed.Jan 29 2025, 2:35 PM

Reproduction steps:

curl -H 'X-Wikimedia-Debug: backend=k8s-mwdebug-next' 'https://www.wikidata.org/w/api.php?action=wbparsevalue&errorformat=plaintext&format=json&options=%7B%22lang%22%3A%22ja%22%7D&parser=time&uselang=ja&values=%1F2016'
Stashbot added a comment.Jan 29 2025, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-29T14:46:04Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1114995|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1114994|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1115012|Handle null date format in MwDateFormatParserFactory (T384963)]], [[gerrit:1115010|Handle null date format in MwDateFormatParserFactory (T384963)]]

Stashbot added a comment.Jan 29 2025, 2:50 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-29T14:50:32Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:1114995|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1114994|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1115012|Handle null date format in MwDateFormatParserFactory (T384963)]], [[gerrit:1115010|Handle null date format in MwDateFormatParserFactory (T384963)]] synced to the

Stashbot added a comment.Jan 29 2025, 2:58 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-29T14:58:25Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1114995|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1114994|Handle missing monthonly format in MwTimeIsoFormatter (T384867)]], [[gerrit:1115012|Handle null date format in MwDateFormatParserFactory (T384963)]], [[gerrit:1115010|Handle null date format in MwDateFormatParserFactory (T384963)]] (duration:

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.14; 2025-01-28); removed MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 29 2025, 3:00 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for Deployment Window to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jan 29 2025, 3:00 PM

We check back in a few days that the errors aren’t showing up anymore.

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Jan 29 2025, 6:46 PM
gerritbot added a comment.Jan 30 2025, 2:38 PM

Change #1115407 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_43] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115407

gerritbot added a comment.Jan 30 2025, 3:31 PM

Change #1115434 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_42] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115434

gerritbot added a comment.Jan 30 2025, 4:20 PM

Change #1115407 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_43] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115407

gerritbot added a comment.Jan 30 2025, 4:30 PM

Change #1115434 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_42] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1115434

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2025, 5:53 PM
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Jan 30 2025, 6:29 PM
Reedy changed the task status from Open to In Progress.Jan 31 2025, 1:08 PM
gerritbot added a comment.Feb 3 2025, 2:15 PM

Change #1116809 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1116809

gerritbot added a project: Patch-For-Review.Feb 3 2025, 2:15 PM
gerritbot added a comment.Feb 3 2025, 2:41 PM

Change #1116809 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_39] Handle null date format in MwDateFormatParserFactory

https://gerrit.wikimedia.org/r/1116809

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2025, 3:30 PM
karapayneWMDE claimed this task.Feb 7 2025, 1:50 PM
karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
karapayneWMDE closed this task as Resolved.Feb 13 2025, 8:29 AM
karapayneWMDE removed karapayneWMDE as the assignee of this task.
karapayneWMDE moved this task from In Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
karapayneWMDE subscribed.
jhsoby mentioned this in T391423: Special:Block MultiBlocks: Opening active blocks table using the Norwegian Bokmål (no) language causes exception.Apr 9 2025, 7:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits