Page MenuHomePhabricator
Create Task
Maniphest T384995

InvalidArgumentException: Invalid language code "nv</big>"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: Invalid language code "nv</big>"
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.13/includes/language/LanguageFactory.php(192)
#0/srv/mediawiki/php-1.44.0-wmf.13/includes/language/LanguageFactory.php(178)MediaWiki\Languages\LanguageFactory->newFromCode(string)
#1/srv/mediawiki/php-1.44.0-wmf.13/includes/libs/MapCacheLRU.php(271)MediaWiki\Languages\LanguageFactory->MediaWiki\Languages\{closure}()
#2/srv/mediawiki/php-1.44.0-wmf.13/includes/language/LanguageFactory.php(179)MapCacheLRU->getWithSetCallback(string, Closure)
#3/srv/mediawiki/php-1.44.0-wmf.13/includes/language/LanguageFactory.php(152)MediaWiki\Languages\LanguageFactory->getRawLanguage(string)
#4/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/LoginSignupSpecialPage.php(1284)MediaWiki\Languages\LanguageFactory->getLanguage(string)
#5/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/LoginSignupSpecialPage.php(1258)MediaWiki\SpecialPage\LoginSignupSpecialPage->makeLanguageSelectorLink(string, string)
#6/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/LoginSignupSpecialPage.php(638)MediaWiki\SpecialPage\LoginSignupSpecialPage->makeLanguageSelector()
#7/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/LoginSignupSpecialPage.php(625)MediaWiki\SpecialPage\LoginSignupSpecialPage->getPageHtml(string)
#8/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/LoginSignupSpecialPage.php(407)MediaWiki\SpecialPage\LoginSignupSpecialPage->mainLoginForm(array, string, string)
#9/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/SpecialPage.php(729)MediaWiki\SpecialPage\LoginSignupSpecialPage->execute(null)
#10/srv/mediawiki/php-1.44.0-wmf.13/includes/specialpage/SpecialPageFactory.php(1735)MediaWiki\SpecialPage\SpecialPage->run(null)
#11/srv/mediawiki/php-1.44.0-wmf.13/includes/actions/ActionEntryPoint.php(503)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#12/srv/mediawiki/php-1.44.0-wmf.13/includes/actions/ActionEntryPoint.php(145)MediaWiki\Actions\ActionEntryPoint->performRequest()
#13/srv/mediawiki/php-1.44.0-wmf.13/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#14/srv/mediawiki/php-1.44.0-wmf.13/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/index.php(3)require(string)
#16{main}
Impact

The signup/login pages of nvwiki are broken.

Notes

This was caused by this on-wiki change (https://nv.wikipedia.org/w/index.php?title=MediaWiki:Loginlanguagelinks&diff=prev&oldid=308501) which sought to make the login/signup language selector links bigger. Someone with access needs to revert the change.

Additional validation to ignore invalid language codes in the link generation logic may also help here.

Details

Request URL
https://nv.wikipedia.org/w/index.php?returnto=*&returntoquery=*&title=*
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
specialpage: Improve handling of invalid lang codes on login/signupReedymediawiki/coreREL1_43+8 -3
specialpage: Improve handling of invalid lang codes on login/signupReedymediawiki/coreREL1_42+7 -3
specialpage: Improve handling of invalid lang codes on login/signupReedymediawiki/coreREL1_39+7 -3
specialpage: Improve handling of invalid lang codes on login/signupAmmarpadmediawiki/coremaster+8 -3
Customize query in gerrit

Event Timeline

Ammarpad created this task.Jan 29 2025, 6:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2025, 6:51 AM
Ammarpad updated the task description. (Show Details)Jan 29 2025, 7:00 AM
gerritbot added a comment.Jan 29 2025, 8:00 AM

Change #1114948 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1114948

gerritbot added a project: Patch-For-Review.Jan 29 2025, 8:00 AM
Reedy subscribed.Jan 29 2025, 1:49 PM

This was caused by this on-wiki change (https://nv.wikipedia.org/w/index.php?title=MediaWiki:Loginlanguagelinks&diff=prev&oldid=308501) which sought to make the login/signup language selector links bigger. Someone with access needs to revert the change.

https://nv.wikipedia.org/w/index.php?title=MediaWiki%3ALoginlanguagelinks&diff=308512&oldid=308501

gerritbot added a comment.Jan 29 2025, 3:56 PM

Change #1114948 merged by jenkins-bot:

[mediawiki/core@master] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1114948

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 29 2025, 4:00 PM
gerritbot added a comment.Jan 29 2025, 4:04 PM

Change #1115058 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_43] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115058

gerritbot added a comment.Jan 29 2025, 4:07 PM

Change #1115060 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_42] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115060

gerritbot added a comment.Jan 29 2025, 4:11 PM

Change #1115065 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_39] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115065

Jdforrester-WMF subscribed.Jan 29 2025, 5:07 PM

I don't think it's worth backporting to wmf.14 (or wmf.13), so I think this is Resolved?

Ammarpad updated the task description. (Show Details)Jan 29 2025, 7:13 PM
Ammarpad added a comment.Jan 29 2025, 7:23 PM
In T384995#10505438, @Jdforrester-WMF wrote:

I don't think it's worth backporting to wmf.14 (or wmf.13), so I think this is Resolved?

Yes.

Ammarpad claimed this task.Jan 29 2025, 7:24 PM
Jdforrester-WMF closed this task as Resolved.Jan 29 2025, 8:00 PM
gerritbot added a comment.Jan 29 2025, 8:12 PM

Change #1115065 merged by jenkins-bot:

[mediawiki/core@REL1_39] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115065

gerritbot added a comment.Jan 29 2025, 8:16 PM

Change #1115060 merged by jenkins-bot:

[mediawiki/core@REL1_42] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115060

gerritbot added a comment.Jan 29 2025, 8:20 PM

Change #1115058 merged by jenkins-bot:

[mediawiki/core@REL1_43] specialpage: Improve handling of invalid lang codes on login/signup

https://gerrit.wikimedia.org/r/1115058

ReleaseTaggerBot added projects: MW-1.43-notes, MW-1.39-notes, MW-1.42-notes.Jan 29 2025, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 30 2025, 5:52 PM
Krinkle moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits