Page MenuHomePhabricator
Create Task
Maniphest T385045

Colours on Wikidata Lexemes are not appearing correctly in dark mode on Vector 2022
Closed, ResolvedPublic
Actions

Description

Problem
Currently, the colours on Lexeme pages are not appearing correctly on dark mode: https://wikidata.beta.wmflabs.org/wiki/Lexeme:L57525?vectornightmode=1&useskin=vector-2022

image.png (968×1 px, 182 KB)

Solution

We will assign Codex colour tokens to the elements on the page so that they work across light and dark modes and align with Wikimedia frontend standards.

See Figma file for more info. (Figma tip: double-click repeatedly to “drill down” into elements until you’ve selected the one that has the color tokens.)

Acceptance Criteria

  • The colours for all the elements have been converted to their equivalent Codex colour tokens in light-mode

Notes
Not all colours have an equivalent token; in some cases, we accept that light mode colours will slightly change
By assigning the correct colour tokens the colours will automatically work across light and dark mode

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Jan 29 2025, 2:45 PM
karapayneWMDE added a project: Wikidata-Omega.Mar 12 2025, 2:10 PM
karapayneWMDE moved this task from Incoming to The Backlog on the Wikidata-Omega board.
Arian_Bozorg updated the task description. (Show Details)Mar 12 2025, 2:14 PM
hoo claimed this task.Mar 17 2025, 7:14 PM
hoo moved this task from The Backlog to The Board on the Wikidata-Omega board.
hoo edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
hoo moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
hoo removed hoo as the assignee of this task.Mar 18 2025, 8:21 PM
hoo moved this task from In Development to Product Verification on the Wikidata-Omega (The Board) board.
hoo subscribed.

After 85f3478386615aa1bdb6dd6929fb5b75ea65b1ff this seems to work analogue to items and properties: https://wikidata.beta.wmflabs.org/wiki/Lexeme:L1?vectornightmode=1&useskin=vector-2022

Given that the changes done to the style sheets for items/ properties applied previously, I think it is safe to assume that further changes done in that context (eg. for statement edit mode) will apply to Lexeme without further action.

Arian_Bozorg closed this task as Resolved.Fri, Apr 4, 12:46 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

Looks good!

The editing state should be covered in T389633

karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Fri, Apr 11, 7:59 AM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q1 on the Wikidata-Omega (Completed Tasks) board.Fri, Apr 11, 8:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits