We noticed you closed this PR, are you still working on it? If you are, please feel free to move the ticket back to the Doing column, but in the meantime I'll put it in blocked and waiting.

Thanks so much!

GOlson-WMF moved this task from Waiting for Build to Blocked or Waiting on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 3 2025, 7:39 PM

Hi @GOlson-WMF

Sorry yes, I'm still working on the task. I've moved the task back to doing from review. Will send out PR once i've tested everything one more time.

PR: https://github.com/wikimedia/wikipedia-ios/pull/5183

HNordeenWMF mentioned this in T385397: [BUG] Search results content visible beneath status bar in Explore tab.Feb 4 2025, 7:02 PM

GOlson-WMF moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 5 2025, 6:46 PM

GOlson-WMF moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 7 2025, 3:44 PM

This is fixed on 7.7.1 (4936), but the keyboard no longer auto-hides when scrolling results.

HNordeenWMF moved this task from Ready for PM Signoff to Did not pass QA on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 11 2025, 8:11 PM

HNordeenWMF subscribed.

This comment was removed by HNordeenWMF.

HNordeenWMF moved this task from Did not pass QA to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 11 2025, 10:00 PM

@ABorbaWMF This is the same behavior in Explore tab and I observed this while testing.

Thanks @Chandrapg ! My understanding was that you've put in a fix for Explore: T385397, and a separate fix for Search with this current task.

It's fixed on Explore, but I am still seeing the bug on Search with these steps:

Open Search Tab
Initiate Search results by typing in bar and choosing blue "Search" button on keyboard
Navigate to another root view like Saved
Go back to Search Tab and start scrolling on results

Version: 7.7.1 (4944)

@HNordeenWMF The issue in the current task specifically relates to scroll behavior in the Search tab. The fix for this is already included in PR #5183.

However, the steps you outlined describe an issue similar to what I reported in T385397—which I’m already aware of. I have a fix for that in a separate branch, but I was waiting for the current fix to be deployed first, as the issue you reported cannot be reproduced without the fix in PR #5183.

My understanding is that each bug should have an associated task rather than merging multiple issues into a single task. However, if you’d prefer to include a fix similar to T385397 in PR #5183, I’m happy to update the PR accordingly.

Let me know how you’d like to proceed!

Hi @Chandrapg,
It's ok to solve the sample problem happening in multiple places or scenarios on the same task, or have multiple PRs on the same task if they're all related to fixing the same bug.
But since the follow-up fix is depending on this one deploying, I've created a separate task T386274 for the steps I mentioned above & added you.

HNordeenWMF moved this task from Did not pass QA to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 12 2025, 9:36 PM

HNordeenWMF closed this task as Resolved.Feb 13 2025, 3:35 PM

HNordeenWMF removed Chandrapg as the assignee of this task.

HNordeenWMF added a subscriber: Chandrapg.

[BUG] Search results content visible beneath status barClosed, ResolvedPublicBUG REPORTActions

Description

Steps to reproduce

Expected results

Actual results

Screenshots

Environments observed

Related Objects

Event Timeline

[BUG] Search results content visible beneath status bar
Closed, ResolvedPublicBUG REPORT
Actions