| Etonkovidova | |
| Jan 29 2025, 10:17 PM |
| F58319380: Screen Shot 2025-01-30 at 3.21.59 PM.png | |
| Jan 30 2025, 11:24 PM |
To be re-checked after wmf.14 deployment
(1) mediawiki.structured_task.article.link_suggestion_interaction - the logstash link
message: '.homepage_pageview_token' should be string
Note:
(2) eventlogging_HelpPanel - the logstash link
.event.help_panel_session_id' should be string
Note: the error rate is high ~ 5, 785 in 24 hours
Thanks for catching this! Interesting. I checked in Logstash, and it seems that homepage_pageview_token seems to be null, while the Help panel session id tends to have a numeric value. I looked through the code, and I found this line:
this.clickId = parseInt( url.searchParams.get( 'geclickid' ) );
in modules/ext.growthExperiments.SuggestedEditSession/index.js. This line would indeed generate an integer, while the schema expects a string (rightfully so;geclickid is alphanumeric, such as 3hn2k5op8h9vq7iae3n2rjge3db0jh03).
This line of code changed in the wmf.12 train, specifically, in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1097428. The previous code was this.clickId = url.query.geclickid;.
Since that patch changes a lot of instrumentation-related code, I wouldn't be surprised if the null value in homepage_pageview_token would be also caused by that patch, especially since both errors started appearing at the same time.
This is breaking instrumentation for Structured tasks at least, and presumably for other features too. Pulling to sprint, this needs to be addressed.
FYI @KStoller-WMF @Iflorez .
Change #1115376 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditSession: remove incorrect cast to integer
Change #1115383 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.13] SuggestedEditSession: remove incorrect cast to integer
Change #1115384 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.14] SuggestedEditSession: remove incorrect cast to integer
Change #1115383 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.13] SuggestedEditSession: remove incorrect cast to integer
Change #1115384 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.14] SuggestedEditSession: remove incorrect cast to integer
Mentioned in SAL (#wikimedia-operations) [2025-01-30T14:37:23Z] <hashar@deploy2002> Started scap sync-world: Backport for [[gerrit:1115383|SuggestedEditSession: remove incorrect cast to integer (T385117)]], [[gerrit:1115384|SuggestedEditSession: remove incorrect cast to integer (T385117)]]
Mentioned in SAL (#wikimedia-operations) [2025-01-30T14:44:26Z] <hashar@deploy2002> hashar, sgimeno: Backport for [[gerrit:1115383|SuggestedEditSession: remove incorrect cast to integer (T385117)]], [[gerrit:1115384|SuggestedEditSession: remove incorrect cast to integer (T385117)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2025-01-30T14:51:04Z] <hashar@deploy2002> Finished scap sync-world: Backport for [[gerrit:1115383|SuggestedEditSession: remove incorrect cast to integer (T385117)]], [[gerrit:1115384|SuggestedEditSession: remove incorrect cast to integer (T385117)]] (duration: 13m 41s)
Change #1115376 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditSession: remove incorrect cast to integer
