Page MenuHomePhabricator

Web install process for sqlite db does not adequately check permissions
Open, Needs TriagePublicBUG REPORT

Description

Version 1.43.0
Line 125 of includes/installer/SqliteInstaller.php is:

if ( !is_readable( $dir ) ) {

but $dir must be both readable and writable.

Steps to replicate the issue (include links if applicable):

Make the directory unwritable and watch the installer fail to create the sqlite db.

(Have I tried this, no. )

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Not installed. 1.43.0 tarball.

Event Timeline

Change #1123091 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] installer: Check whether the data directory is writable

https://gerrit.wikimedia.org/r/1123091

Change #1123091 merged by jenkins-bot:

[mediawiki/core@master] installer: Check whether the data directory is writable

https://gerrit.wikimedia.org/r/1123091