Page MenuHomePhabricator

Alert on console errors for group 0, 1 and 2
Closed, ResolvedPublic

Description

In T385055 one thing that could be automated to find it is to alert if the console has errors. And guess what, we already collect console errors in our performance tests :) But we do not alert on them.

We mostly do one page tests but we have the user login journey and T373172. When more user journeys is implemented we should make sure we include those pages in the alerts.

For now let me add alerts for the pages we have, that is the least amount of work that can be done to give us a chance to find this automatically in the future.

Event Timeline

I added alerts for the user journey tests on enwiki for desktop and emulated mobile as a first start(here, scroll down to "Console errors"). And added dashboards for group 0 and group 1 first view tests but alerts yet, I want to test it some more.

I need to spend some time and verify that we pickup the actually errors in the report before we navigate to a new page. I implemented getting the errors many years ago and I need to verify that through a user journey we pickup every error that comes though the console (and not only the ones that happens when we start to measure and stop to measure the performance). I'll verify how it works tomorrow.

Chrome handles the logs like this: When you start a new browser the logs are empty and then it continues to collect them until you ask to get them. That means that if we do a user journey, we will get all the logs that has been created since start. That means we will not miss any errors and will be safe with the current checks we have.

I created alerts now for the login user journey, mediawiki.org and it.wikipedia.org (with desktop and mobile). The alerts lives in https://grafana.wikimedia.org/d/000000318/performance-synthetic-direct-test-alerts . I tried with console alerts on WebPageReplay tests but we inject some JavaScript that potentially can create errors in the log (I've seen it in a couple of URLS) so its safer to add the logs to the direct tests.