Page MenuHomePhabricator

Dashboard forgets my source and target languages
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open the unified dashboard (source/target languages are es/en by default)
  • Change source/target languages to en/sat (or anything)
  • Click on a translation suggestion (article or section)
  • Land on the translation confirmation view
  • Click the X button to go back to the dashboard

What happens?:

  • source/target languages are set back to default: es/en

What should have happened instead?:

  • source/target languages are still what I set them to: en/sat

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Derived Requirement

The unified dashboard should persist the user’s selected source and target languages across navigation actions, ensuring that:

  • When a user changes the source/target languages, the selection should remain unchanged.
  • After clicking on a translation suggestion and navigating to the translation confirmation view, the selected languages should still be retained when returning to the dashboard.
Test Steps

Test Case 1: Ensure Source and Target Languages Persist After Returning to Dashboard

  1. Open the unified dashboard (default languages should be es/en).
  2. Change the source language to English (en) and the target language to Santali (sat) (or any other combination).
  3. Click on a translation suggestion (either an article or section).
  4. Land on the translation confirmation view.
  5. Click the X button to return to the dashboard.
  6. ✅❓❌⬜ AC1: Confirm that the source and target languages remain as en/sat and do not revert to es/en.

QA Results - Test Wiki

ACStatusDetails
1T385287#10584758

Event Timeline

SBisson triaged this task as Medium priority.
SBisson moved this task from Backlog to In-progress on the LPL Hypothesis board.

Change #1117226 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Preserve url params when exiting confirmation step

https://gerrit.wikimedia.org/r/1117226

PWaigi-WMF changed the task status from Open to In Progress.Feb 6 2025, 8:48 AM
PWaigi-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

Change #1117226 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Preserve url params when exiting confirmation step

https://gerrit.wikimedia.org/r/1117226

Change #1118478 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250210

https://gerrit.wikimedia.org/r/1118478

Change #1118478 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250210

https://gerrit.wikimedia.org/r/1118478

Change #1118856 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Properly remove 'page' parameter when exiting confirm step

https://gerrit.wikimedia.org/r/1118856

Change #1118856 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Properly remove 'page' parameter when exiting confirm step

https://gerrit.wikimedia.org/r/1118856

Change #1119533 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Clear all translation URL params when going back to dashboard

https://gerrit.wikimedia.org/r/1119533

Change #1119533 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Clear all translation URL params when going back to dashboard

https://gerrit.wikimedia.org/r/1119533

Change #1120157 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250217

https://gerrit.wikimedia.org/r/1120157

Change #1120157 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250217

https://gerrit.wikimedia.org/r/1120157

@SBisson Confirmed that the source and target languages remain as en/sat and do not revert to es/en as seen in the gifs below. I will move this to sign-off. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&filter-type=automatic&filter-id=previous-edits&active-list=suggestions&from=es&to=en&unified-dashboard=true#/
https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&filter-type=automatic&filter-id=previous-edits&active-list=suggestions&from=es&to=en&unified-dashboard=true#/

Test Steps

Test Case 1: Ensure Source and Target Languages Persist After Returning to Dashboard

  1. Open the unified dashboard but with the link above (default languages should be es/en).
  2. Change the source language to English (en) and the target language to Santali (sat) (or any other combination).
  3. Click on a translation suggestion (either an article or section).
  4. Land on the translation confirmation view.
  5. Click the X button to return to the dashboard.
  6. AC1: Confirm that the source and target languages remain as en/sat and do not revert to es/en.
DesktopMobile
2025-02-26_12-47-24.mp4.gif (850×806 px, 1 MB)
2025-02-26_12-37-07.mp4.gif (698×322 px, 801 KB)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.