Page MenuHomePhabricator

MenuItem with check icon: explore other solutions to indicate selection
Open, Needs TriagePublic

Assigned To
None
Authored By
bmartinezcalvo
Feb 3 2025, 12:02 PM
Referenced Files
F58346466: image.png
Feb 3 2025, 12:02 PM
F58346464: image.png
Feb 3 2025, 12:02 PM
F58345263: image.png
Feb 3 2025, 12:02 PM

Description

Background

In T371998, we included a check icon in MenuItem to indicate multi-selection in menus. We decided to use this check icon solely for multi-selection, relying on the color of the selected menu item to indicate single-selection. Since MenuItems can also support actions or other indicators placed on the right (as noted in T383909), the check icon should not be used in these cases to prevent the menus from becoming too complex and cluttered. Additionally, using the check icon inconsistently may lead to confusion.

For this reason, we could explore alternative solutions for the check icon that do not compete with the other elements of the menu item when they are all displayed.

User stories

  • As a user, I need to clearly understand when items are selected in menus, including multi-selection options, and ensure that different elements of the menu do not compete, allowing me to scan them all easily.

Possible solutions

image.png (664×696 px, 54 KB)
image.png (664×696 px, 53 KB)
Current behaviorProposed solution

Design spec

Once a component spec sheet has been created in Figma, remove the note stating that the spec is missing and link to the spec below.

Component spec sheet

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

Design

  • Design the Figma spec sheet and add it in this task
  • Update the component in the Figma library. This step will be done by a DST member.

Code

  • Implement the component in Codex