Author: frazzleddad
Description:
Line number is off when showing changes
When using "Show Changes" the line number is off by one.
Safari 5.1.5 on OSx Lion.
http://en.wikisource.org/w/index.php?title=Page:The_book_of_try_and_learn.djvu/1&action=submit
Repro: Edit page, change text on first line. Click "Show Changes".
Expected: Line Number at top should show Line 1
Actual: Line number shows Line 2
Version: unspecified
Severity: normal
Attached:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| add labels to projects instead of building separate array | repos/releng/bitergia-sources-updater!1 | brennen | work/add_label | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T39139 Bugs found by WTA (tracking) | |||
| Resolved | GOIII | T38552 Diff incorrectly reports incorrect line numbers |
Moving to Proofread Extension. This is not a bug in MediaWiki core, which does everything just fine (try it on a simple sandbox page).
The proofread extension is using some hacky javascript implementation that, when the page loads, removes part of the javascript and puts it back in when submitting the form. That first line isn't miscalculated, it is really there.
I can't reproduce this effect no matter if my Prefs are set to show or hide the Proofread Page: header & footer fields first.
I think this resolved (inadvertently) with the refactoring of the extension back in January ( Bugzilla 46616 ).
This issue was resolved back when the Page: namespace's diff layout was changed to address all three possible "fields" (i.e. textareas better known as header, body & footer). Closing