Summary
When users log in to an account on WMF wikis, the CheckUser extension logs this. On a wiki with SUL3 enabled this code is called when the transaction profiler expects no writes.
Background
- CheckUser creates a private CheckUser event when a user logs in, logs out, or creates an account
- SUL3 causes the login flow to be changed, and as part of this it appears that login on the local wiki is performed using a GET request
- CheckUser currently assumes that logins can only occur on POST requests, so does not handle a case when logging is performed via a GET request for the purposes of the transaction profiler
Technical notes
- To solve, this the code could do one of the following ideas:
- If the login is performed via a method which expects no writes, then either insert the private event post send or in a job
- Make SUL3 perform the request to the local wiki use a POST request
- Mark the inserts to the CheckUser tables as ignored by the transaction profiler
Acceptance criteria
- TransactionProfiler warnings are no longer created when a user logs in on a SUL3 enabled wiki