Page MenuHomePhabricator
Create Task
Maniphest T385567

PHP Warning: Undefined array key 1 in ParsoidRenderID
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: Undefined array key 1
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.14/includes/edit/ParsoidRenderID.php(40)
#0/srv/mediawiki/php-1.44.0-wmf.14/includes/edit/ParsoidRenderID.php(40)MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.14/includes/Rest/Handler/Helper/HtmlInputTransformHelper.php(373)MediaWiki\Edit\ParsoidRenderID::newFromKey(string)
#2/srv/mediawiki/php-1.44.0-wmf.14/includes/Rest/Handler/Helper/HtmlInputTransformHelper.php(132)MediaWiki\Rest\Handler\Helper\HtmlInputTransformHelper->initInternal(MediaWiki\Title\Title, array, array, null, MediaWiki\Language\Language)
#3/srv/mediawiki/php-1.44.0-wmf.14/includes/Rest/Handler/Helper/PageRestHelperFactory.php(206)MediaWiki\Rest\Handler\Helper\HtmlInputTransformHelper->__construct(Wikimedia\Stats\StatsFactory, MediaWiki\Parser\Parsoid\HtmlTransformFactory, MediaWiki\Edit\SimpleParsoidOutputStash, MediaWiki\Page\ParserOutputAccess, MediaWiki\Page\PageStore, MediaWiki\Revision\RevisionStore, array, MediaWiki\Title\Title, array, array, null, MediaWiki\Language\Language)
#4/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/DirectParsoidClient.php(103)MediaWiki\Rest\Handler\Helper\PageRestHelperFactory->newHtmlInputTransformHelper(array, MediaWiki\Title\Title, array, array, null, MediaWiki\Language\Language)
#5/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/DirectParsoidClient.php(199)MediaWiki\Extension\VisualEditor\DirectParsoidClient->getHtmlInputTransformHelper(MediaWiki\Title\Title, string, int, string, MediaWiki\Language\Language)
#6/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/ApiParsoidTrait.php(119)MediaWiki\Extension\VisualEditor\DirectParsoidClient->transformHTML(MediaWiki\Title\Title, MediaWiki\Language\Language, string, int, string)
#7/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(252)MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->transformHTML(MediaWiki\Title\Title, string, int, string)
#8/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(226)MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->getWikitextNoCache(MediaWiki\Title\Title, array, array)
#9/srv/mediawiki/php-1.44.0-wmf.14/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(414)MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->getWikitext(MediaWiki\Title\Title, array, array)
#10/srv/mediawiki/php-1.44.0-wmf.14/includes/api/ApiMain.php(1973)MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->execute()
#11/srv/mediawiki/php-1.44.0-wmf.14/includes/api/ApiMain.php(941)MediaWiki\Api\ApiMain->executeAction()
#12/srv/mediawiki/php-1.44.0-wmf.14/includes/api/ApiMain.php(912)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#13/srv/mediawiki/php-1.44.0-wmf.14/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#14/srv/mediawiki/php-1.44.0-wmf.14/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#15/srv/mediawiki/php-1.44.0-wmf.14/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#16/srv/mediawiki/w/api.php(3)require(string)
#17{main}
Impact
Notes

POST API request

See also: T385568: InvalidArgumentException: Bad key: -1" OR 2+583-583-1=0+0+0+1 --

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
parser: Gracefully handle invalid ParsoidRenderID keysReedymediawiki/coreREL1_43+36 -2
parser: Gracefully handle invalid ParsoidRenderID keysMáté Szabómediawiki/coremaster+36 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERROR• mszaboT385567 PHP Warning: Undefined array key 1 in ParsoidRenderID
· · ·

Event Timeline

jijiki created this task.Feb 4 2025, 12:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2025, 12:06 PM
jijiki added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Feb 4 2025, 12:06 PM
Reedy updated the task description. (Show Details)Feb 4 2025, 12:18 PM
Reedy mentioned this in T385568: InvalidArgumentException: Bad key: -1" OR 2+583-583-1=0+0+0+1 -- .
gerritbot added a comment.Feb 4 2025, 12:19 PM

Change #1117175 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] parser: Gracefully handle invalid ParsoidRenderID keys

https://gerrit.wikimedia.org/r/1117175

gerritbot added a project: Patch-For-Review.Feb 4 2025, 12:19 PM
gerritbot added a comment.Feb 4 2025, 2:38 PM

Change #1117175 merged by jenkins-bot:

[mediawiki/core@master] parser: Gracefully handle invalid ParsoidRenderID keys

https://gerrit.wikimedia.org/r/1117175

Reedy added a subtask: T385588: PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated.Feb 4 2025, 2:46 PM
gerritbot added a comment.Feb 4 2025, 2:54 PM

Change #1117201 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/core@REL1_43] parser: Gracefully handle invalid ParsoidRenderID keys

https://gerrit.wikimedia.org/r/1117201

Reedy changed the task status from Open to In Progress.Feb 4 2025, 2:56 PM
Reedy removed a subtask: T385588: PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated.
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 4 2025, 3:00 PM
gerritbot added a comment.Feb 4 2025, 3:59 PM

Change #1117201 merged by jenkins-bot:

[mediawiki/core@REL1_43] parser: Gracefully handle invalid ParsoidRenderID keys

https://gerrit.wikimedia.org/r/1117201

ReleaseTaggerBot added a project: MW-1.43-notes.Feb 4 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2025, 4:30 PM
Pppery added projects: VisualEditor, MediaWiki-REST-API.Feb 6 2025, 5:35 AM
Reedy closed this task as Resolved.Feb 21 2025, 9:49 PM
Reedy assigned this task to • mszabo.
Krinkle moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:40 AM
Reedy renamed this task from PHP Warning: Undefined array key 1 to PHP Warning: Undefined array key 1 in ParsoidRenderID.Apr 21 2025, 3:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits