Summary
On a SUL3 enabled wiki, the MediaWiki-extensions-LoginNotify extension causes two emails to be sent for the same successful login from a new device.
Background
- When testing CheckUser with SUL3 and finding T385572: SUL3: CheckUser is told about two successful logins with different IP addresses for one successful login on a SUL3 enabled wiki, I found that I was emailed twice about a login from a new device
- The email had the same content and the timestamps match with the login events stored in CheckUser
- This appears to be the same issue where the IP address is different for the different calls to the AuthManagerAuthenticateAudit hook for the same login
User story
- As a user, I log into my account from a new device
- I see two emails indicating I've logged in from a new device
- I am worried that someone else has logged into my account, as it appears two new devices have been used to log into my account
Technical notes
- Appears to be AuthManagerAuthenticateAudit being called twice for the same successful login
- Fix may be the same as T385572, but may be different if calling the hook twice is going to remain
Acceptance criteria
- Only one MediaWiki-extensions-LoginNotify email is sent for a successful login attempt from a new device