Page MenuHomePhabricator

Issues with benevity import after bookworm update
Closed, ResolvedPublic

Description

@EMartin is having issues with benevity imports after the bookworm upgrade yesterday. The updates appear stalled in the UI.

imports.png (201×1 px, 43 KB)

Additionally, the following is syslog for the imports:

Feb  4 22:17:32 civi1002 civicrm.wmf[1398041]: https://civicrm.wikimedia.org|1738707452|php|98.97.41.1|https://civicrm.wikimedia.org/batch?id=3919&op=do_nojs&op=do|https://civicrm.wikimedia.org/batch?op=start&id=3919|554||TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in implode() (line 336 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/offline2civicrm/offline2civicrm.module).
Feb  4 22:19:00 civi1002 civicrm.wmf[1346856]: https://civicrm.wikimedia.org|1738707540|php|98.97.41.1|https://civicrm.wikimedia.org/batch?id=3920&op=do_nojs&op=do|https://civicrm.wikimedia.org/batch?op=start&id=3920|554||TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in implode() (line 336 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/offline2civicrm/offline2civicrm.module).
Feb  4 22:21:25 civi1002 civicrm.wmf[1354417]: https://civicrm.wikimedia.org|1738707685|php|98.97.41.1|https://civicrm.wikimedia.org/batch?id=3921&op=do_nojs&op=do|https://civicrm.wikimedia.org/batch?op=start&id=3921|554||TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in implode() (line 336 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/offline2civicrm/offline2civicrm.module).

In addition to the functional error, there are some warnings that are clouding the UI output which may cause additional doubt and stress.

import_warnings.png (901×1 px, 990 KB)

Opening this task to track discussions that are happening in slack and irc.

Event Timeline

Change #1117280 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix deprecations by simplifying to an array

https://gerrit.wikimedia.org/r/1117280

Change #1117281 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Fix implode param order

https://gerrit.wikimedia.org/r/1117281

Change #1117280 merged by Eileen:

[wikimedia/fundraising/crm@master] Fix deprecations by simplifying to an array

https://gerrit.wikimedia.org/r/1117280

Change #1117281 merged by Eileen:

[wikimedia/fundraising/crm@master] Fix implode param order

https://gerrit.wikimedia.org/r/1117281

greg triaged this task as Unbreak Now! priority.Feb 5 2025, 5:06 PM
greg moved this task from Backlog to Done on the Fundraising Tech - Chaos Crew board.
greg subscribed.
greg lowered the priority of this task from Unbreak Now! to High.Feb 5 2025, 5:06 PM
greg moved this task from Triage to Chaos Crew Backlog on the Fundraising-Backlog board.

(meh, putting to High instead of UBN! to not confuse people, this is done though, just waiting for our bi-weekly end of sprint review before closing.)

XenoRyet set Final Story Points to 4.