Page MenuHomePhabricator
Create Task
Maniphest T385669

Extract backlink marker renderer service for both parsers
Closed, ResolvedPublic
Actions

Description

Currently the rendering for backlink markers to done differently in the legacy parser and Parsoid. That's why any changes to that system need to be implemented in two places.

We want to create code that can be used for both parsers so that we're also able to implement changes for Sub-referencing (product board) and the new backlink marker configurations easier.

Implementation details

  • Extract the backlink parsing from the legacy parser.
  • Make switchable between legacy and new backlinks.
  • Provide an easy interface that can also be used in Parsoid code.

T384948: Implement explicit backlink markers for Parsoid comes in follow-up work.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Replace recursion in BacklinkMarkRenderer with loopThiemo Kreuz (WMDE)mediawiki/extensions/Citemaster+18 -34
Add missing test cases for the CLDR Alphabets integrationThiemo Kreuz (WMDE)mediawiki/extensions/Citemaster+8 -1
Remove unused test setup related to BacklinkMarkRendererThiemo Kreuz (WMDE)mediawiki/extensions/Citemaster+3 -22
Backlink mark rendering serviceAwightmediawiki/extensions/Citemaster+380 -310
Drop error message when running out of backlink labelsThiemo Kreuz (WMDE)mediawiki/extensions/Citemaster+5 -27
Fall back to numeric backlink labels when legacy sequence is exhaustedAwightmediawiki/extensions/Citemaster+12 -21
Rename feature flag to general "legacy" backlinksAwightmediawiki/extensions/Citemaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Feb 5 2025, 10:06 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 5 2025, 10:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-Fisch mentioned this in T384948: Implement explicit backlink markers for Parsoid.Feb 5 2025, 10:07 AM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-02-05 board.
WMDE-Fisch added a parent task: T384291: Use a configurable Alphabet to generate backlink markers in Cite (Parsoid).
gerritbot added a comment.Feb 5 2025, 10:09 AM

Change #1115446 had a related patch set uploaded (by WMDE-Fisch; author: Awight):

[mediawiki/extensions/Cite@master] Backlink mark rendering service

https://gerrit.wikimedia.org/r/1115446

gerritbot added a project: Patch-For-Review.Feb 5 2025, 10:09 AM
WMDE-Fisch moved this task from Incoming to In progress on the WMDE-References-FocusArea board.Feb 6 2025, 9:39 AM
gerritbot added a comment.Feb 6 2025, 11:19 AM

Change #1117872 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Rename feature flag to general "legacy" backlinks

https://gerrit.wikimedia.org/r/1117872

gerritbot added a comment.Feb 6 2025, 11:55 AM

Change #1117872 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Rename feature flag to general "legacy" backlinks

https://gerrit.wikimedia.org/r/1117872

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 6 2025, 5:00 PM
gerritbot added a comment.Feb 7 2025, 9:41 AM

Change #1088295 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop error message when running out of backlink labels

https://gerrit.wikimedia.org/r/1088295

awight removed awight as the assignee of this task.Feb 7 2025, 9:45 AM
awight subscribed.
gerritbot added a comment.Feb 7 2025, 1:20 PM

Change #1118111 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fall back to numeric backlink labels when legacy sequence is exhausted

https://gerrit.wikimedia.org/r/1118111

gerritbot added a comment.Feb 10 2025, 1:01 PM

Change #1118111 abandoned by Awight:

[mediawiki/extensions/Cite@master] Fall back to numeric backlink labels when legacy sequence is exhausted

Reason:

Will merge I7bb4c86701cef697 instead.

https://gerrit.wikimedia.org/r/1118111

gerritbot added a comment.Feb 11 2025, 10:06 AM

Change #1088295 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop error message when running out of backlink labels

https://gerrit.wikimedia.org/r/1088295

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18); removed: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 11 2025, 11:00 AM
gerritbot added a comment.Feb 11 2025, 11:20 AM

Change #1115446 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Backlink mark rendering service

https://gerrit.wikimedia.org/r/1115446

awight claimed this task.Feb 11 2025, 11:20 AM
awight updated the task description. (Show Details)
awight moved this task from Tech Review to Doing on the WMDE-TechWish-Sprint-2025-02-05 board.
awight removed awight as the assignee of this task.Feb 11 2025, 11:24 AM
awight updated the task description. (Show Details)
awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2025-02-05 board.

Remaining work is already split out as T384948: Implement explicit backlink markers for Parsoid.

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2025-02-05 board.Feb 14 2025, 11:31 AM
thiemowmde closed this task as Resolved.Feb 18 2025, 12:52 PM
gerritbot added a comment.Mar 18 2025, 10:05 AM

Change #1128812 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove unused test setup related to BacklinkMarkRenderer

https://gerrit.wikimedia.org/r/1128812

gerritbot added a comment.Apr 4 2025, 5:39 PM

Change #1128812 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove unused test setup related to BacklinkMarkRenderer

https://gerrit.wikimedia.org/r/1128812

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18).Apr 4 2025, 6:00 PM
gerritbot added a comment.Jun 18 2025, 8:20 AM

Change #1160687 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add missing test cases for the CLDR Alphabets integration

https://gerrit.wikimedia.org/r/1160687

gerritbot added a comment.Jun 18 2025, 11:28 AM

Change #1160687 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add missing test cases for the CLDR Alphabets integration

https://gerrit.wikimedia.org/r/1160687

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 18 2025, 12:01 PM
gerritbot added a comment.Jun 20 2025, 7:36 AM

Change #1161823 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Replace recursion in BacklinkMarkRenderer with loop

https://gerrit.wikimedia.org/r/1161823

gerritbot added a comment.Jun 20 2025, 10:13 AM

Change #1161823 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Replace recursion in BacklinkMarkRenderer with loop

https://gerrit.wikimedia.org/r/1161823

thiemowmde mentioned this in T335189: Investigation: When do Cite errors appear? (Scraper).Apr 17 2026, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits