Page MenuHomePhabricator

CheckUser IP reveal guidance dialog: Make IPInfo preference check apply globally if GlobalPreferences extension installed
Closed, ResolvedPublic

Description

Summary

The IP reveal guidance panel allows users to check the IP Info extension preference to enable the tool. However, this preference check applies locally. We should apply this globally, so that users can use the tool everywhere they have rights to use it.

Background

  • The IP reveal guidance dialog allows users to check the IP Info extension preference to enable the tool
    • This preference is shown in the second IPInfo step and is only shown if the preference is enabled
  • Checking this preference only locally would mean that the user would need to enable the preference on all wikis they use the tool
    • This is annoying for users such as stewards, who are active on many small wikis
  • Checking the preference globally for all users avoids the need to show the dialog again on other wikis

Technical notes

  • This should be possible to achieve without too much work, though we would need to consider whether the value of the preference before the dialog opens should be the state of the global preference or the local one

Acceptance criteria

Event Timeline

Change #1117915 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [Very WIP] Make IPInfo preference global

https://gerrit.wikimedia.org/r/1117915

Dreamy_Jazz changed the task status from Open to Stalled.EditedFeb 6 2025, 6:11 PM

Stalled on the completion of T298977

Dreamy_Jazz changed the task status from Stalled to Open.May 30 2025, 1:37 PM

Progress can start again.

Change #1117915 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Check IPInfo preference globally in onboarding dialog

https://gerrit.wikimedia.org/r/1117915

Djackson-ctr subscribed.

The new code changes have been verified and are functioning as expected (Per the Acceptance Criteria).