Page MenuHomePhabricator

CheckUser IP reveal guidance dialog: Make dialog only appear once for users on all wikis for a multi-wiki install
Closed, ResolvedPublic

Description

Summary

The IP reveal guidance panel is shown only once for a user. This check is currently implemented per-wiki, but this should be implemented such that the dialog is only shown once for all wikis.

Background

  • The IP reveal guidance panel is only intended to be shown once per user
  • This is implemented via a preference which is currently set locally, even when MediaWiki-extensions-GlobalPreferences is installed
  • If the dialog is shown once per-wiki it will be annoying for users such as stewards on WMF wikis where they will see the dialog up to 800 times

Technical notes

  • Should just involve setting the preference globally where this is possible. We should be able to read the value of the local preference for whether to display the dialog, as the global preference being set would set the local preference implicitly.

Acceptance criteria

  • The IP reveal guidance dialog is only shown once for a given user even on a wikifarm install (such as all WMF wikis)

Event Timeline

Change #1153132 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Mark onboarding dialog as seen globally

https://gerrit.wikimedia.org/r/1153132

Change #1153132 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Mark onboarding dialog as seen globally

https://gerrit.wikimedia.org/r/1153132

Djackson-ctr subscribed.

The new code changes have been verified and are functioning as expected (Per the Acceptance Criteria).