Page MenuHomePhabricator

FunctionViewerDetailsTable: pagination is missing from tables with less than 5 columns
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Go to https://www.wikifunctions.org/wiki/Z10000
  2. Implementations table has pagination disabled

Observed behavior:

In FunctionViewerDetailsTable.vue component, CdxTable is passed this paginate prop:

<cdx-table                           
  ...                   
  :paginate="columns.length > 5"

This should not be columns, but rows. Pagination should be activated whenever there are more rows than 5.


Completion checklist

Event Timeline

Change #1117850 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix paginate prop in CdxTable

https://gerrit.wikimedia.org/r/1117850

gengh renamed this task from FunctionViewerDetailsTable: pagination is missing from tables with less than 5 columsn to FunctionViewerDetailsTable: pagination is missing from tables with less than 5 columns.Feb 6 2025, 9:47 AM

Change #1117850 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix paginate prop in CdxTable

https://gerrit.wikimedia.org/r/1117850

Jdforrester-WMF subscribed.

Confirmed as fixed in prod.