Page MenuHomePhabricator
Create Task
Maniphest T385790

Cover the Scoped Typeahead Search Vue component with tests
Closed, ResolvedPublic
Actions

Description

The prototype implementation of Scoped Typeahead Search (T384730) doesn't include any unit / integration tests. These should be implemented before the component is released to users. We have some existing Jest tests for Wikibase and also the QUnit suite - developer should decide which of these makes more sense.

Acceptance Criteria

  • The Scoped Typeahead Search component is covered by tests
    • At least functionality in the original acceptance criteria T384730 is covered
  • The tests run automatically as part of the Wikibase CI jobs

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add tests for ScopedTypeaheadSearchmediawiki/extensions/Wikibasemaster+2 K -69
Set up Jest tests for ScopedTypeaheadSearchmediawiki/extensions/Wikibasemaster+3 K -269
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Feb 6 2025, 11:42 AM
ArthurTaylor renamed this task from Cover the Scoped Typeahead Search Vue component with tests to [SW] Cover the Scoped Typeahead Search Vue component with tests.
ArthurTaylor added a parent task: T338483: [EPIC] Implement ScopedTypeaheadSearch component.
ArthurTaylor moved this task from Incoming to Product Backlog on the [Archived]Wikidata Dev Team board.
ArthurTaylor mentioned this in T384730: Implement a standalone prototype of the ScopedTypeaheadSearch component.
ArthurTaylor renamed this task from [SW] Cover the Scoped Typeahead Search Vue component with tests to Cover the Scoped Typeahead Search Vue component with tests.Feb 12 2025, 1:55 PM
ArthurTaylor updated the task description. (Show Details)
ArthurTaylor moved this task from Product Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Feb 17 2025, 10:45 AM
karapayneWMDE edited projects, added Wikidata-Omega; removed [Archived]Wikidata Dev Team.Mar 10 2025, 10:38 AM
karapayneWMDE moved this task from Incoming to The Backlog on the Wikidata-Omega board.
Lucas_Werkmeister_WMDE claimed this task.Mar 13 2025, 1:22 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

See: https://www.mediawiki.org/wiki/Vue.js/Testing

gerritbot added a comment.Mar 13 2025, 3:39 PM

Change #1127547 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Set up Jest tests for ScopedTypeaheadSearch

https://gerrit.wikimedia.org/r/1127547

gerritbot added a project: Patch-For-Review.Mar 13 2025, 3:39 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 17 2025, 11:03 AM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.
ArthurTaylor claimed this task.Mar 17 2025, 11:37 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 17 2025, 11:50 AM
ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 17 2025, 12:02 PM

Change #1127547 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Set up Jest tests for ScopedTypeaheadSearch

https://gerrit.wikimedia.org/r/1127547

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2025, 12:32 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Ready for Development on the Wikidata-Omega (The Board) board.Mar 17 2025, 12:46 PM
karapayneWMDE edited projects, added Wikidata-Omega; removed Wikidata-Omega (The Board).Mar 20 2025, 11:16 AM
hoo claimed this task.Mar 25 2025, 5:32 PM
hoo moved this task from The Backlog to The Board on the Wikidata-Omega board.
hoo edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
hoo moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
hoo removed hoo as the assignee of this task.Mar 26 2025, 7:06 PM
hoo moved this task from In Development to Ready for Development on the Wikidata-Omega (The Board) board.
hoo added subscribers: AudreyPenven_WMDE, hoo.

I didn't manage to make much progress. Current state in @AudreyPenven_WMDE's https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1123003.

AudreyPenven_WMDE claimed this task.Mar 31 2025, 2:49 PM
AudreyPenven_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Apr 2 2025, 9:58 AM

Change #1133352 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] [WIP] Add tests for ScopedTypeaheadSearch

https://gerrit.wikimedia.org/r/1133352

gerritbot added a project: Patch-For-Review.Apr 2 2025, 9:58 AM
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Apr 2 2025, 3:55 PM
AudreyPenven_WMDE moved this task from In Development to Ready for Development on the Wikidata-Omega (The Board) board.

Since I'm going to be on vacation for rest of the week, I'm moving this back to Ready for Development.

The current status is that the jest tests are working now. The ScopedTypeaheadSearch Vue component and its children are able to be successfully mounted. There are a couple very basic tests as well as some titles of tests I intended to write, but didn't get to. There's some TODOs around things that need fixing or to otherwise be done differently.

AudreyPenven_WMDE claimed this task.Apr 7 2025, 9:24 AM
AudreyPenven_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Apr 14 2025, 12:35 PM
AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor claimed this task.Apr 14 2025, 1:39 PM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Apr 14 2025, 3:24 PM
ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Apr 14 2025, 3:46 PM

Change #1133352 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add tests for ScopedTypeaheadSearch

https://gerrit.wikimedia.org/r/1133352

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2025, 4:30 PM
karapayneWMDE closed this task as Resolved.Apr 17 2025, 7:32 AM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.
karapayneWMDE moved this task from In Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.Apr 17 2025, 7:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits