Page MenuHomePhabricator

Cross-device warning shown when working only on desktop with new translation dashboard
Closed, ResolvedPublic

Description

Content Translation provides two platform-specific editors that process contents differently: the desktop editor works with the full article and the mobile editor. The unified dashboard is able to direct users to the appropriate editor, and informs the user when continuing a translation that was started with a different editor (T351893).

However, currently the cross-device warning is shown even when the translation is started and continued on desktop.

Steps:

  1. Starting a translation on desktop with the new unified dashboard in Test Wiki for Karura forest
  2. Add some contents to the translation and return to the dashboard.
  3. Select the option to start a new translation and search for Karura forest.
  4. The tool provides the option to continue with the translation.
  5. After selecting the option to "continue" a warning dialog is shown explaining that the translation was started in a different device.

This is illustrated in this video (scaled down to adhere to Phab video size limits):

The expected behaviour would be:

  • The warning not to show when continuing on desktop, a translation that was started also on desktop.
  • Don't perform any splitting of the translation into sections when continuing the translation on desktop. I don't know if splitting is actually happening since I was not translating beyond the lead section, but we may want to double-check.

Event Timeline

ngkountas moved this task from Backlog to Prioritized on the LPL Hypothesis board.
ngkountas moved this task from Needs Triage to Bugs on the ContentTranslation board.

Change #1118524 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Unified Dashboard: Do not show the cross-device warning on desktop

https://gerrit.wikimedia.org/r/1118524

Change #1118524 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Unified Dashboard: Do not show the cross-device warning on desktop

https://gerrit.wikimedia.org/r/1118524

I tested this issue on test wiki with the exact same article as in the task description, and the cross-device warning is no longer shown on desktop. Moving this task to Design Signoff column.

Screencast from test wiki on desktop (the warning is not shown):

Screencast from test wiki on mobile (the warning is shown):

Pginer-WMF moved this task from Design Signoff to Product Signoff on the LPL Hypothesis board.

I tried both cases, with a translation that includes only contents form the lead section and a translation including contents from other sections. Works as expected: users can continue their translation where they left it, with no warning shown.