Page MenuHomePhabricator
Create Task
Maniphest T385806

Replace `{{#parsoid-fragment}}` with dedicated token
Closed, ResolvedPublic
Actions

Description

Replacing {{#parsoid-fragment}} with a dedicated token (maybe using a character sequence like strip markers use on the core side) would also allow us to /not/ expandTemplates again when processing the fragment returned by a parser function.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.22.0-a25mediawiki/vendormaster+2 K -2 K
Move parsoid fragment marker processing into the tokenizermediawiki/services/parsoidmaster+2 K -2 K
Bump wikimedia/parsoid to 0.22.0-a13mediawiki/vendormaster+1 K -2 K
Don't expand template-like strings returned from the preprocessormediawiki/services/parsoidmaster+93 -79
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Feb 6 2025, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2025, 3:12 PM
SLopes-WMF moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Mar 13 2025, 2:31 PM
gerritbot added a comment.May 9 2025, 11:24 PM

Change #1140966 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: new curly-brace tokenizer based on the preprocessor

https://gerrit.wikimedia.org/r/1140966

gerritbot added a project: Patch-For-Review.May 9 2025, 11:24 PM
gerritbot added a comment.Jul 18 2025, 12:06 AM

Change #1170441 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Don't expand template-like strings returned from the preprocessor

https://gerrit.wikimedia.org/r/1170441

gerritbot added a comment.Jul 19 2025, 9:47 AM

Change #1170441 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Don't expand template-like strings returned from the preprocessor

https://gerrit.wikimedia.org/r/1170441

ABreault-WMF claimed this task.Jul 21 2025, 7:08 PM
ABreault-WMF triaged this task as Medium priority.
ABreault-WMF added a project: Content-Transform-Team (Work In Progress).
ABreault-WMF moved this task from Backlog to To Deploy on the Content-Transform-Team (Work In Progress) board.
gerritbot added a comment.Jul 21 2025, 9:44 PM

Change #1171282 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a13

https://gerrit.wikimedia.org/r/1171282

gerritbot added a comment.Jul 21 2025, 10:17 PM

Change #1171282 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a13

https://gerrit.wikimedia.org/r/1171282

ABreault-WMF removed ABreault-WMF as the assignee of this task.Jul 24 2025, 10:36 PM
ABreault-WMF removed a project: Content-Transform-Team (Work In Progress).
ABreault-WMF subscribed.

would also allow us to /not/ expandTemplates again when processing the fragment returned by a parser function.

1170441 let us stop setting expandTemplates by always expanding {{#parsoid-fragment}}. But maybe we still want a dedicated token?

cscott added a parent task: T388786: Follow up from Parsoid Fragment support.Sep 14 2025, 3:10 AM
gerritbot added a comment.Sep 14 2025, 3:26 AM

Change #1187961 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Move parsoid fragment marker processing into the tokenizer

https://gerrit.wikimedia.org/r/1187961

gerritbot added a comment.Sep 21 2025, 6:21 AM

Change #1187961 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Move parsoid fragment marker processing into the tokenizer

https://gerrit.wikimedia.org/r/1187961

gerritbot added a comment.Sep 29 2025, 4:20 PM

Change #1192167 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a25

https://gerrit.wikimedia.org/r/1192167

gerritbot added a comment.Sep 29 2025, 7:29 PM

Change #1192167 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a25

https://gerrit.wikimedia.org/r/1192167

cscott closed this task as Resolved.Thu, Mar 26, 2:36 PM
cscott claimed this task.
Jgiannelos mentioned this in T419726: Parsoid fails to expand transclusion generated by a Lua module on mnwiki.Tue, Mar 31, 10:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits