Page MenuHomePhabricator

Add favourite button to template form in VisualEditor
Closed, ResolvedPublic8 Estimated Story Points

Description

At this point in the T377978 story, it is possible to favourite a template when searching for it in the initial template-search form. This task is to also add a fabourite button to the template editing form that is used both just after selecting a new template and also when clicking the edit button on a template that's already in a wiki page.

This task is only for aadding this to VE; see T385846 for the equivalent for adding to TemplateWizard.

The design is at https://www.figma.com/design/QWD6oDEz9NMEnF2ppVc4Xq/Template-recall-and-discovery?node-id=765-7127&t=zZvtDAHJ3iCCcutY-4

Screenshot from 2025-02-07 08-16-48.png (368×1 px, 217 KB)

Event Timeline

KSiebert set the point value for this task to 8.Mar 6 2025, 10:49 AM

Change #1130616 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/VisualEditor@master] [WIP] ve.ui.MWTemplatePage: Add Favorite button if enabled

https://gerrit.wikimedia.org/r/1130616

Change #1135038 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: Make FavoriteStore available

https://gerrit.wikimedia.org/r/1135038

Change #1135038 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: Make FavoriteStore available

https://gerrit.wikimedia.org/r/1135038

Change #1130616 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplatePage: Add Favorite button if enabled

https://gerrit.wikimedia.org/r/1130616

dom_walden subscribed.

From where I'm sitting, I can see your favourite button.