Page MenuHomePhabricator

Fix Automoderator using the wrong edit summary (individual edit instead of Rollback-style)
Closed, ResolvedPublic2 Estimated Story Points

Description

In T375056 we made it so that Automoderator does a 'rollback' - undoing every sequential recent edit by the user being reverted. This means it can revert multiple edits in one action.

Its revert message, however, implies it only reverts one edit:

Undo revision [[Special:Diff/$1|$1]] by [[Special:Contributions/$2|$2]]

When editors rollback an edit, the edit summary used is:

Reverted edits by USER (talk) to last version by USER2

We should probably use the same message in Automoderator when we are reverting more than one edit. USER2 is the most recent editor prior to the first edit we're reverting.

We should also delete the system messages since they are no longer needed.

Event Timeline

Actually, what are these messages used for currently? They look like the ones we'd want to use.

Screenshot 2025-02-07 at 13.13.38.png (432×1 px, 146 KB)

@Samwalton9-WMF These are the correct messages.
There's a bug here
We don't want to be setting the summary on rollback to the undo summary which we were passing into the AutoModeratorFetchRevScoreJob.
In fact, do we even need these undo summary messages anymore?

automoderator-wiki-undo-summary
automoderator-wiki-undo-summary-anon

@Samwalton9-WMF These are the correct messages.
There's a bug here
We don't want to be setting the summary on rollback to the undo summary which we were passing into the AutoModeratorFetchRevScoreJob.
In fact, do we even need these undo summary messages anymore?

automoderator-wiki-undo-summary
automoderator-wiki-undo-summary-anon

Good find! Yeah I don't think we need these anymore if we start using the correct messages :)

Samwalton9-WMF renamed this task from Update Automoderator's default edit summary given that it may now rollback multiple edits, not just one to Fix Automoderator using the wrong edit summary (individual edit instead of Rollback-style).Feb 17 2025, 9:37 PM
Scardenasmolinar set the point value for this task to 2.
Scardenasmolinar moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.
Scardenasmolinar changed the task status from Open to In Progress.Feb 19 2025, 7:47 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change #1121118 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Change AutoModerator's edit summary

https://gerrit.wikimedia.org/r/1121118

Change #1121118 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Change AutoModerator's edit summary

https://gerrit.wikimedia.org/r/1121118

jsn.sherman subscribed.

Verified working on testwiki; leaving open until train finishes rolling out.
See example
https://test.wikipedia.org/w/index.php?title=Kuzari&oldid=648386

This should now be resolved - please confirm if this is still an issue @SCP-2000!

@Samwalton9-WMF Hello, I can confirm it has been resolved. Thank you:)