Odd warning when merging and searching
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SHust
	Feb 7 2025, 5:50 PM

Description

I'm flagging the odd warning I'm getting when merging records in civi, which isn't preventing the merge itself:

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Fix php notices	wikimedia/fundraising/crm	master	+5 -2
Further fix for notices - fix custom field 'data_type'	wikimedia/fundraising/crm	master	+25 -0
Fix up website records	wikimedia/fundraising/crm	master	+22 -0

Customize query in gerrit

Related Objects

Mentioned In: T386137: 2025 Sprint C Priorities / End of sprint summary

Event Timeline

SHust created this task.Feb 7 2025, 5:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2025, 5:50 PM

SHust renamed this task from Odd warning when merging records to Odd warning when merging and searching.Feb 10 2025, 4:09 PM

I'm also getting an error message today when selecting "Find Contributions"

At the top of the page you can see a large error message as shown in the image below.

Not sure it's affecting usability which is good..

Chaos tied to PHP upgrade @Eileenmcnaughton

@AMJohnson we will fix this but you can safely ignore it in the meantime

Change #1118590 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix up website records

https://gerrit.wikimedia.org/r/1118590

gerritbot added a project: Patch-For-Review.Feb 10 2025, 11:57 PM

I just put up a patch for the merge thing - the issue with original_amount is the field is of type String but on our locals it is of type Money - which seems right

Change #1118593 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Further fix for notices - fix custom field 'data_type'

https://gerrit.wikimedia.org/r/1118593

Eileenmcnaughton added a project: Fundraising Tech - Chaos Crew.Feb 11 2025, 1:52 AM

Eileenmcnaughton moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.

AKanji-WMF added a project: Fundraising Sprint Bibimbap.Feb 11 2025, 8:17 PM

AKanji-WMF edited projects, added Fundraising Sprint: Churros; removed Fundraising Sprint Bibimbap.Feb 11 2025, 9:34 PM

Eileenmcnaughton moved this task from Backlog to Ready for Review on the Fundraising Sprint: Churros board.Feb 11 2025, 10:00 PM

Change #1118590 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix up website records

https://gerrit.wikimedia.org/r/1118590

Change #1118593 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Further fix for notices - fix custom field 'data_type'

https://gerrit.wikimedia.org/r/1118593

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2025, 12:30 AM

@AMJohnson these should be gone now - let us know if you see others

Will do @Eileenmcnaughton. Thank you!

Just came across another one. While searching for contributions by name using Advanced Search I switched from searching by "Contacts" to searching by "Contributions" and when I hit search I received the error message below.

Thanks @AMJohnson - just FYI these warnings are not new but they became visible as a result of the php upgrade last week. In general this extra visibility is a good thing because they let us know something is 'not as expected' - in the case of the first 2 it was minor data issues although these can also be code related. I'll dig in & see what this one is

Change #1119240 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix php notices

https://gerrit.wikimedia.org/r/1119240

gerritbot added a project: Patch-For-Review.Feb 13 2025, 12:41 AM

Change #1119240 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix php notices

https://gerrit.wikimedia.org/r/1119240

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 3:30 AM

AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.Feb 13 2025, 8:30 PM

XenoRyet closed this task as Resolved.Feb 24 2025, 8:26 PM

XenoRyet set Final Story Points to 4.

Damilare mentioned this in T386137: 2025 Sprint C Priorities / End of sprint summary.Feb 25 2025, 9:08 PM