Page MenuHomePhabricator

Puppet broken on deployment-restbase05
Closed, ResolvedPublicBUG REPORT

Description

bd808@deployment-restbase05:~$ sudo -i puppet agent -tv
Info: Using environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, One and only one listener with name 'mw-parsoid' is expected (file: /srv/puppet_code/environments/production/modules/wmflib/functions/service/get_url.pp, line: 77, column: 13) on node deployment-restbase05.deployment-prep.eqiad1.wikimedia.cloud
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Event Timeline

This looks to be fallout from https://gerrit.wikimedia.org/r/c/operations/puppet/+/1117997. When profile::restbase::parsoid_uri is not found in a hiera lookup Puppet tries to construct a default value with wmflib::service::get_url('mw-parsoid', '/w/rest.php', $listeners) and that is apparently busted in deployment-prep.

I think we can just add a dummy placeholder value.

Mentioned in SAL (#wikimedia-releng) [2025-02-07T21:33:55Z] <bd808> Added profile::restbase::parsoid_uri: https://phabricator.wikimedia.org/T385902 to deployment-restbase prefix puppet (T385902)

bd808 claimed this task.