Page MenuHomePhabricator

{{Wikiproject banner shell}} no longer requires 1= parameter
Closed, ResolvedPublicBUG REPORT

Description

Genfixes for {{Wikiproject banner shell}} "Adds explicit call to first unnamed parameter |1= if missing." (To test, try [[Talk:Abersychan School]])

However, this parameter is no longer required, per [[Template:WikiProject banner shell/doc]].
Therefore, please remove this functionality from the genfixes.

Thanks!

Event Timeline

rev 12863 TalkPageFixes: {{Wikiproject banner shell}} no longer requires 1= parameter so don't insert it, or rely on it when setting blp=

@GoingBatty What should AWB do when moving WikiProjects templates into bannershell? Currently AWB does that by using/setting the 1= parameter. Have all existing templates been cleaned to not use 1=, or does AWB need to use 1= if present, otherwise handle it not being used?

Switch:

{{Wikiproject banner shell|1=
{{banner1}}
{{banner2}}
}}

to:

{{Wikiproject banner shell|
{{banner1}}
{{banner2}}
}}

So we don't up with people removing the |1= and others adding it.

@Rjwilmsi - When I searched article talk pages for

hastemplate:"WikiProject banner shell" insource:/WikiProject banner shell.*?\|1=/

I found 963,108 results before the regex timed out.
Since the use of 1= is optional and doesn't change how the template is displayed to the reader, my suggestion is to neither add nor remove it, unless the code is also doing something else (e.g. moving another banner into the shell)

Rjwilmsi claimed this task.

rev 12865 TalkPageFixes: {{Wikiproject banner shell}} no longer requires 1= parameter: when adding templates use 1= if already there, else add without.